]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: qcom-ethqos: correct prg_rclk_dly comment
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 27 Mar 2026 08:44:34 +0000 (08:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 31 Mar 2026 00:36:46 +0000 (17:36 -0700)
The comment for calculating the prg_rclk_dly value is incorrect as it
omits the brackets around the divisor. Add the brackets to allow the
reader to correctly evaluate the value. Validated with the values given
in the driver.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Link: https://patch.msgid.link/E1w62ny-0000000E3D8-38Yp@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

index 9dae40c27903d283e00474bf0c00d71e82df7d48..667676c29a95aaaba5290424308424a3500143e2 100644 (file)
@@ -450,8 +450,10 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed)
                rgmii_setmask(ethqos, SDCC_DDR_CONFIG_EXT_PRG_RCLK_DLY_EN,
                              SDCC_HC_REG_DDR_CONFIG);
        } else {
-               /* PRG_RCLK_DLY = TCXO period * TCXO_CYCLES_CNT / 2 * RX delay ns,
-                * in practice this becomes PRG_RCLK_DLY = 52 * 4 / 2 * RX delay ns
+               /* PRG_RCLK_DLY = TCXO period * TCXO_CYCLES_CNT /
+                *  (2 * RX delay ns),
+                * in practice this becomes PRG_RCLK_DLY = 52 * 4 /
+                *  (2 * RX delay ns)
                 */
                if (ethqos->has_emac_ge_3) {
                        /* 0.9 ns */