removed gcc compilation flag -Wbad-function-cast

It makes it more difficult to directly cast the result of a function,
requiring to store the result in an intermediate variable.
It does not necessarily help readability,
and this restriction can be difficult to overcome in some constructions,
like some macros.

also : fixed minor Visual conversion warnings in datagencli.c

diff --git a/lib/Makefile b/lib/Makefile
index cc109944d5e7c0d02b27bac129e98df75fd5a784..f492c6bd1e32384955d8713982eb1cc78d19d4c8 100644 (file)
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -23,10 +23,10 @@ VERSION?= $(LIBVER)
 CPPFLAGS+= -I. -I./common -DXXH_NAMESPACE=ZSTD_
 CFLAGS  ?= -O3
 DEBUGFLAGS = -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow \
-           -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
-           -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security \
-           -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \
-           -Wbad-function-cast -Wredundant-decls
+            -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
+            -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security \
+            -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \
+            -Wredundant-decls
 CFLAGS  += $(DEBUGFLAGS) $(MOREFLAGS)
 FLAGS    = $(CPPFLAGS) $(CFLAGS)
 

diff --git a/programs/Makefile b/programs/Makefile
index 9efa00074965abe21650e0a77c98f2ea265b5632..ab2db7284b0a4230039910f1fae0bf6852f6ef4f 100644 (file)
--- a/programs/Makefile
+++ b/programs/Makefile
@@ -42,10 +42,10 @@ CPPFLAGS+= -I$(ZSTDDIR) -I$(ZSTDDIR)/common -I$(ZSTDDIR)/compress \
            -DXXH_NAMESPACE=ZSTD_   # because xxhash.o already compiled with this macro from library
 CFLAGS  ?= -O3
 DEBUGFLAGS = -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow \
-          -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
-          -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security \
-          -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \
-          -Wbad-function-cast -Wredundant-decls
+            -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
+            -Wstrict-prototypes -Wundef -Wpointer-arith -Wformat-security \
+            -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \
+            -Wredundant-decls
 CFLAGS  += $(DEBUGFLAGS) $(MOREFLAGS)
 FLAGS    = $(CPPFLAGS) $(CFLAGS) $(LDFLAGS)
 

diff --git a/tests/Makefile b/tests/Makefile
index 560c36e1f80e80b494e033833fc9c63f57f0d728..c275c081f96cbb9a0ac357350ca6e03a377fa568 100644 (file)
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -32,10 +32,10 @@ CPPFLAGS+= -I$(ZSTDDIR) -I$(ZSTDDIR)/common -I$(ZSTDDIR)/compress \
            $(DEBUGFLAG)
 CFLAGS  ?= -O3
 CFLAGS  += -Wall -Wextra -Wcast-qual -Wcast-align -Wshadow \
-           -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
-           -Wstrict-prototypes -Wundef -Wformat-security \
-           -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \
-           -Wbad-function-cast -Wredundant-decls
+            -Wstrict-aliasing=1 -Wswitch-enum -Wdeclaration-after-statement \
+            -Wstrict-prototypes -Wundef -Wformat-security \
+            -Wvla -Wformat=2 -Winit-self -Wfloat-equal -Wwrite-strings \
+            -Wredundant-decls
 CFLAGS  += $(MOREFLAGS)
 FLAGS    = $(CPPFLAGS) $(CFLAGS) $(LDFLAGS)
 

diff --git a/tests/datagencli.c b/tests/datagencli.c
index 3bb634b75e6bea75aa6c0ad08fd2f4ab7cc0d427..8a81939d16de19c91e2092a4a915bc60eed4e3ad 100644 (file)
--- a/tests/datagencli.c
+++ b/tests/datagencli.c
@@ -95,10 +95,10 @@ int main(int argc, const char** argv)
                     break;
                 case 'P':
                     argument++;
-                    probaU32=0.0;
+                    probaU32 = 0;
                     while ((*argument>='0') && (*argument<='9'))
                         probaU32 *= 10, probaU32 += *argument++ - '0';
-                    if (probaU32>100.) probaU32=100.;
+                    if (probaU32>100) probaU32 = 100;
                     break;
                 case 'L':   /* hidden argument : Literal distribution probability */
                     argument++;