]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpu: nova-core: use CStr::from_bytes_until_nul() in elf64_section()
authorJohn Hubbard <jhubbard@nvidia.com>
Tue, 6 Jan 2026 03:52:26 +0000 (19:52 -0800)
committerDanilo Krummrich <dakr@kernel.org>
Wed, 7 Jan 2026 18:36:11 +0000 (19:36 +0100)
Instead of open-coding the steps for extracting a null-terminated
string, use the newly available CStr::from_bytes_until_nul().

Suggested-by: Joel Fernandes <joelagnelf@nvidia.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Link: https://patch.msgid.link/20260106035226.48853-3-jhubbard@nvidia.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/nova-core/firmware/gsp.rs

index da97814cf85964296ccdc918798e421331c8be0f..1025b7f746eb3401cc0c04ca4180cc6fc20fefd2 100644 (file)
@@ -93,10 +93,7 @@ mod elf {
 
             // Get the start of the name.
             elf.get(name_idx..)
-                // Stop at the first `0`.
-                .and_then(|nstr| nstr.get(0..=nstr.iter().position(|b| *b == 0)?))
-                // Convert into CStr. This should never fail because of the line above.
-                .and_then(|nstr| CStr::from_bytes_with_nul(nstr).ok())
+                .and_then(|nstr| CStr::from_bytes_until_nul(nstr).ok())
                 // Convert into str.
                 .and_then(|c_str| c_str.to_str().ok())
                 // Check that the name matches.