Accessing a list global to the module means it's thread un-safe

The list should probably be changed to an RBtree for speed.

diff --git a/src/modules/rlm_radutmp/rlm_radutmp.c b/src/modules/rlm_radutmp/rlm_radutmp.c
index 8fae770be0361bd34cac8bc4435e97f45d2a84db..27739b03c14d5ef42a5392c0543e8f6b407df319 100644 (file)
--- a/src/modules/rlm_radutmp/rlm_radutmp.c
+++ b/src/modules/rlm_radutmp/rlm_radutmp.c
@@ -731,7 +731,7 @@ static int radutmp_checksimul(void *instance, REQUEST *request)
 module_t rlm_radutmp = {
        RLM_MODULE_INIT,
        "radutmp",
-       RLM_TYPE_CHECK_CONFIG_SAFE | RLM_TYPE_HUP_SAFE,         /* type */
+       RLM_TYPE_THREAD_UNSAFE | RLM_TYPE_CHECK_CONFIG_SAFE | RLM_TYPE_HUP_SAFE,        /* type */
        radutmp_instantiate,          /* instantiation */
        radutmp_detach,               /* detach */
        {