Add eslint no-undef rule and resolve errors

diff --git a/js/.eslintrc b/js/.eslintrc
index 9c66e07332645a4842751e751126fd6ddac1f866..b8c38b3428d47f2492ed5805f44ee7029f472c07 100644 (file)
--- a/js/.eslintrc
+++ b/js/.eslintrc
@@ -2,7 +2,8 @@
     "root": true,
     "parser": "babel-eslint",
     "env": {
-        "browser": true
+        "browser": true,
+        "jquery": true
     },
     "rules": {
 
@@ -98,7 +99,7 @@
         "no-label-var": 2,
         "no-shadow": 0,
         "no-shadow-restricted-names": 2,
-        "no-undef": 0,
+        "no-undef": 2,
         "no-undefined": 0,
         "no-undef-init": 2,
         "no-unused-vars": 2,

diff --git a/js/src/modal.js b/js/src/modal.js
index 99a49f148f926265caaf48fd6b531db38a2d5de4..a5f0160c9cc00eff17c3a40d2b889f60a970bee2 100644 (file)
--- a/js/src/modal.js
+++ b/js/src/modal.js
@@ -138,7 +138,7 @@ const Modal = (($) => {
       $(this._dialog).on(Event.MOUSEDOWN_DISMISS, () => {
         $(this._element).one(Event.MOUSEUP_DISMISS, (event) => {
           if ($(event.target).is(this._element)) {
-            that._ignoreBackdropClick = true
+            this._ignoreBackdropClick = true
           }
         })
       })

diff --git a/js/src/tooltip.js b/js/src/tooltip.js
index b80bd8e8c972a3d285090f4531e4e65bbf700d61..749e42379b5fb326c4b97110c9787e82c9577e6f 100644 (file)
--- a/js/src/tooltip.js
+++ b/js/src/tooltip.js
@@ -1,3 +1,5 @@
+/* global Tether */
+
 import Util from './util'