]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
tools/cgsnapshot: Fix Coverity uninitialized variable warning
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Mon, 31 Mar 2025 14:11:12 +0000 (19:41 +0530)
committerTom Hromatka <tom.hromatka@oracle.com>
Tue, 1 Apr 2025 21:41:18 +0000 (15:41 -0600)
Coverity reported the following uninitialized variable warning:

CID 465887: (#1 of 1): Uninitialized scalar variable (UNINIT)
32. uninit_use_in_call: Using uninitialized value *wl_file when calling load_list.

Fix the issue by initializing the char[] wl_file with '\0', and also
initialize dl_file similarly as a best practice.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/tools/cgsnapshot.c

index d77be0dd254412c9a3ff7980fff4cec00213a969..95ca39602cd8b47b8c310ae94e8c9b5af8b71b68 100644 (file)
@@ -743,8 +743,8 @@ int main(int argc, char *argv[])
        };
 
        cont_name_t wanted_cont[CG_CONTROLLER_MAX];
-       char bl_file[FILENAME_MAX];  /* denylist file name */
-       char wl_file[FILENAME_MAX];  /* allowlist file name */
+       char bl_file[FILENAME_MAX] = { "\0" };  /* denylist file name */
+       char wl_file[FILENAME_MAX] = { "\0" };  /* allowlist file name */
        int ret = 0, err;
        int c_number = 0;
        int c, i;