]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: mxs-mmc: Fix a resource leak in an error handling path in 'mxs_mmc_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 8 Dec 2020 20:35:27 +0000 (21:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Mar 2021 15:07:20 +0000 (16:07 +0100)
[ Upstream commit 0bb7e560f821c7770973a94e346654c4bdccd42c ]

If 'mmc_of_parse()' fails, we must undo the previous 'dma_request_chan()'
call.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20201208203527.49262-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/mxs-mmc.c

index c8b8ac66ff7e3a4839ba4943c9069e540846c87e..687fd68fbbcd1070437a3b2d33dff9ec7418326b 100644 (file)
@@ -651,7 +651,7 @@ static int mxs_mmc_probe(struct platform_device *pdev)
 
        ret = mmc_of_parse(mmc);
        if (ret)
-               goto out_clk_disable;
+               goto out_free_dma;
 
        mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34;