]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
accel/amdxdna: Clear sva pointer after unbind
authorLizhi Hou <lizhi.hou@amd.com>
Thu, 4 Jun 2026 20:28:15 +0000 (13:28 -0700)
committerLizhi Hou <lizhi.hou@amd.com>
Wed, 10 Jun 2026 06:22:33 +0000 (23:22 -0700)
Add client->sva = NULL after the unbind makes it consistent with how
amdxdna_sva_fini() already clears the pointer after unbinding. The
IS_ERR_OR_NULL guard in sva_fini will then correctly skip the second
unbind.

Fixes: 3cc5d7a59519 ("accel/amdxdna: Add carveout memory support for non-IOMMU systems")
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20260604202815.2425882-1-lizhi.hou@amd.com
drivers/accel/amdxdna/amdxdna_pci_drv.c

index 1f066ed8d23659e97ed1db2b1def62c0b81b8dcf..65489bb3f2b074acc6f92550fd93b4a684e8ef18 100644 (file)
@@ -87,6 +87,7 @@ static int amdxdna_sva_init(struct amdxdna_client *client)
        client->pasid = iommu_sva_get_pasid(client->sva);
        if (client->pasid == IOMMU_PASID_INVALID) {
                iommu_sva_unbind_device(client->sva);
+               client->sva = NULL;
                XDNA_ERR(xdna, "SVA get pasid failed");
                return -ENODEV;
        }