]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: SOF: ipc4-pcm: Delay reporting is only supported for playback direction
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Fri, 9 May 2025 08:59:51 +0000 (11:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:14:01 +0000 (11:14 +0200)
commit 98db16f314b3a0d6e5acd94708ea69751436467f upstream.

The firmware does not provide any information for capture streams via the
shared pipeline registers.

To avoid reporting invalid delay value for capture streams to user space
we need to disable it.

Fixes: af74dbd0dbcf ("ASoC: SOF: ipc4-pcm: allocate time info for pcm delay feature")
Cc: stable@vger.kernel.org
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
Link: https://patch.msgid.link/20250509085951.15696-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/sof/ipc4-pcm.c

index 18fff2df76f97e269e621c1047d0d34ecae4468b..3e6e63bfee3eeb718cb8282ceec53ef52b36dfbc 100644 (file)
@@ -797,7 +797,8 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm
 
                spcm->stream[stream].private = stream_priv;
 
-               if (!support_info)
+               /* Delay reporting is only supported on playback */
+               if (!support_info || stream == SNDRV_PCM_STREAM_CAPTURE)
                        continue;
 
                time_info = kzalloc(sizeof(*time_info), GFP_KERNEL);