]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
perf annotate: Use al->data_nr if possible
authorNamhyung Kim <namhyung@kernel.org>
Sat, 3 Aug 2024 21:13:28 +0000 (14:13 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 5 Aug 2024 19:07:02 +0000 (16:07 -0300)
The data_nr keeps the number of entries in al->data[] so it should use
it when it iterates the array.  The notes->src->nr_events should have
the same number but it'd be natural to use al->data_nr.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240803211332.1107222-2-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/annotate.c

index a2ee4074f7680fd77994a13d5fe6093b86399925..91ad948c89d5b0bd1d80e13f8ead6c6492182869 100644 (file)
@@ -1594,13 +1594,12 @@ bool ui__has_annotation(void)
 
 
 static double annotation_line__max_percent(struct annotation_line *al,
-                                          struct annotation *notes,
                                           unsigned int percent_type)
 {
        double percent_max = 0.0;
        int i;
 
-       for (i = 0; i < notes->src->nr_events; i++) {
+       for (i = 0; i < al->data_nr; i++) {
                double percent;
 
                percent = annotation_data__percent(&al->data[i],
@@ -1672,7 +1671,7 @@ static void __annotation_line__write(struct annotation_line *al, struct annotati
                                     void (*obj__write_graph)(void *obj, int graph))
 
 {
-       double percent_max = annotation_line__max_percent(al, notes, percent_type);
+       double percent_max = annotation_line__max_percent(al, percent_type);
        int pcnt_width = annotation__pcnt_width(notes),
            cycles_width = annotation__cycles_width(notes);
        bool show_title = false;
@@ -1690,7 +1689,7 @@ static void __annotation_line__write(struct annotation_line *al, struct annotati
        if (al->offset != -1 && percent_max != 0.0) {
                int i;
 
-               for (i = 0; i < notes->src->nr_events; i++) {
+               for (i = 0; i < al->data_nr; i++) {
                        double percent;
 
                        percent = annotation_data__percent(&al->data[i], percent_type);