]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: atiixp: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:06:30 +0000 (12:06 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:17 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-49-tiwai@suse.de
sound/pci/atiixp.c
sound/pci/atiixp_modem.c

index 427006be240bd99079e02152b844d66ee4aa9bfc..4f544950ee7bf116379a6cf00d50940587f39491 100644 (file)
@@ -1271,7 +1271,7 @@ static int snd_atiixp_pcm_new(struct atiixp *chip)
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_atiixp_playback_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_atiixp_capture_ops);
        pcm->private_data = chip;
-       strcpy(pcm->name, "ATI IXP AC97");
+       strscpy(pcm->name, "ATI IXP AC97");
        chip->pcmdevs[ATI_PCMDEV_ANALOG] = pcm;
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
@@ -1301,9 +1301,9 @@ static int snd_atiixp_pcm_new(struct atiixp *chip)
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_atiixp_spdif_ops);
        pcm->private_data = chip;
        if (chip->spdif_over_aclink)
-               strcpy(pcm->name, "ATI IXP IEC958 (AC97)");
+               strscpy(pcm->name, "ATI IXP IEC958 (AC97)");
        else
-               strcpy(pcm->name, "ATI IXP IEC958 (Direct)");
+               strscpy(pcm->name, "ATI IXP IEC958 (Direct)");
        chip->pcmdevs[ATI_PCMDEV_DIGITAL] = pcm;
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
@@ -1576,8 +1576,8 @@ static int __snd_atiixp_probe(struct pci_dev *pci,
                return err;
        chip = card->private_data;
 
-       strcpy(card->driver, spdif_aclink ? "ATIIXP" : "ATIIXP-SPDMA");
-       strcpy(card->shortname, "ATI IXP");
+       strscpy(card->driver, spdif_aclink ? "ATIIXP" : "ATIIXP-SPDMA");
+       strscpy(card->shortname, "ATI IXP");
        err = snd_atiixp_init(card, pci);
        if (err < 0)
                return err;
index 8d3083b9b024d46f6e827ed72feeb2d08161aad1..f7417c2bb477653916852c2605122c88b3a7f518 100644 (file)
@@ -982,7 +982,7 @@ static int snd_atiixp_pcm_new(struct atiixp_modem *chip)
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_atiixp_capture_ops);
        pcm->dev_class = SNDRV_PCM_CLASS_MODEM;
        pcm->private_data = chip;
-       strcpy(pcm->name, "ATI IXP MC97");
+       strscpy(pcm->name, "ATI IXP MC97");
        chip->pcmdevs[ATI_PCMDEV_ANALOG] = pcm;
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
@@ -1206,8 +1206,8 @@ static int __snd_atiixp_probe(struct pci_dev *pci,
                return err;
        chip = card->private_data;
 
-       strcpy(card->driver, "ATIIXP-MODEM");
-       strcpy(card->shortname, "ATI IXP Modem");
+       strscpy(card->driver, "ATIIXP-MODEM");
+       strscpy(card->shortname, "ATI IXP Modem");
        err = snd_atiixp_init(card, pci);
        if (err < 0)
                return err;