- Fix Local Memory Leak in cachedb_init(),

  reported by X41 D-Sec.

diff --git a/cachedb/cachedb.c b/cachedb/cachedb.c
index 92217db3db156d9e60e265c9f037773c496f2b22..d5cd8dc553b8c6c2a8db277675a5a00e891507d4 100644 (file)
--- a/cachedb/cachedb.c
+++ b/cachedb/cachedb.c
@@ -244,6 +244,8 @@ cachedb_init(struct module_env* env, int id)
        env->modinfo[id] = (void*)cachedb_env;
        if(!cachedb_apply_cfg(cachedb_env, env->cfg)) {
                log_err("cachedb: could not apply configuration settings.");
+               free(cachedb_env);
+               env->modinfo[id] = NULL;
                return 0;
        }
        /* see if a backend is selected */
@@ -252,6 +254,8 @@ cachedb_init(struct module_env* env, int id)
        if(!(*cachedb_env->backend->init)(env, cachedb_env)) {
                log_err("cachedb: could not init %s backend",
                        cachedb_env->backend->name);
+               free(cachedb_env);
+               env->modinfo[id] = NULL;
                return 0;
        }
        cachedb_env->enabled = 1;

diff --git a/doc/Changelog b/doc/Changelog
index a4f6d873ca1fd273bab8ed519d61fae69375dbf0..cda8f1df664ba560bb63f0408e6da08afe3084e3 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -14,6 +14,8 @@
          reported by X41 D-Sec.
        - Fix Config Injection in create_unbound_ad_servers.sh,
          reported by X41 D-Sec.
+       - Fix Local Memory Leak in cachedb_init(),
+         reported by X41 D-Sec.
 
 19 November 2019: Wouter
        - Fix CVE-2019-18934, shell execution in ipsecmod.