]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: usb: smsc95xx: use phy_do_ioctl_running function
authorEthan Nelson-Moore <enelsonmoore@gmail.com>
Sat, 24 Jan 2026 08:07:51 +0000 (00:07 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 27 Jan 2026 03:27:17 +0000 (19:27 -0800)
The smsc95xx_ioctl function behaves identically to the
phy_do_ioctl_running function. Remove it and use the
phy_do_ioctl_running function directly instead.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260124080751.78488-1-enelsonmoore@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/smsc95xx.c

index de733e0488bf79f916860a5ef94e0c3ad1a734cc..c65402d850c98d68168cf4b3a87254e6c60940bf 100644 (file)
@@ -854,14 +854,6 @@ static const struct ethtool_ops smsc95xx_ethtool_ops = {
        .set_pauseparam = smsc95xx_set_pauseparam,
 };
 
-static int smsc95xx_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
-{
-       if (!netif_running(netdev))
-               return -EINVAL;
-
-       return phy_mii_ioctl(netdev->phydev, rq, cmd);
-}
-
 static void smsc95xx_init_mac_address(struct usbnet *dev)
 {
        u8 addr[ETH_ALEN];
@@ -1139,7 +1131,7 @@ static const struct net_device_ops smsc95xx_netdev_ops = {
        .ndo_get_stats64        = dev_get_tstats64,
        .ndo_set_mac_address    = eth_mac_addr,
        .ndo_validate_addr      = eth_validate_addr,
-       .ndo_eth_ioctl          = smsc95xx_ioctl,
+       .ndo_eth_ioctl          = phy_do_ioctl_running,
        .ndo_set_rx_mode        = smsc95xx_set_multicast,
        .ndo_set_features       = smsc95xx_set_features,
 };