]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:rpc_server/backupkey: Fix leaks
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 27 Jul 2023 23:53:57 +0000 (11:53 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:38 +0000 (04:39 +0000)
Allocate these objects on a shorter-lived memory context.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/rpc_server/backupkey/dcesrv_backupkey.c

index 1c87d3ba64c0cc487b8d65e46c4b734f351406d9..d2c504ffa7dddfa1976d3337497af2b17dc88474 100644 (file)
@@ -100,9 +100,9 @@ static NTSTATUS set_lsa_secret(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_MEMORY;
        }
 
-       ret = ldb_search(ldb, mem_ctx, &res, system_dn, LDB_SCOPE_SUBTREE, attrs,
+       ret = ldb_search(ldb, frame, &res, system_dn, LDB_SCOPE_SUBTREE, attrs,
                           "(&(cn=%s)(objectclass=secret))",
-                          ldb_binary_encode_string(mem_ctx, name2));
+                          ldb_binary_encode_string(frame, name2));
 
        if (ret != LDB_SUCCESS ||  res->count != 0 ) {
                DEBUG(2, ("Secret %s already exists !\n", name2));
@@ -202,7 +202,7 @@ static NTSTATUS get_lsa_secret(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_MEMORY;
        }
 
-       ret = ldb_search(ldb, mem_ctx, &res, system_dn, LDB_SCOPE_SUBTREE, attrs,
+       ret = ldb_search(ldb, tmp_mem, &res, system_dn, LDB_SCOPE_SUBTREE, attrs,
                           "(&(cn=%s Secret)(objectclass=secret))",
                           ldb_binary_encode_string(tmp_mem, name));