mkfs.cramfs: check blocksize user input [cppcheck]

Enhance user input checking and error messaging, while fixing
cppcheck warning.

[disk-utils/mkfs.cramfs.c:729]: (style) Checking if unsigned variable 'blksize' is less than zero.

[kzak@redhat.com: fix coding style]

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/disk-utils/mkfs.cramfs.c b/disk-utils/mkfs.cramfs.c
index 2fe95bf82ff59e75cc0e155772cdde89788eb811..37895a380d56a6a05c3445c589b748b4b4613ebf 100644 (file)
--- a/disk-utils/mkfs.cramfs.c
+++ b/disk-utils/mkfs.cramfs.c
@@ -725,10 +725,15 @@ int main(int argc, char **argv)
                case 'h':
                        usage(MKFS_OK);
                case 'b':
-                       blksize = strtoll_or_err(optarg, _("failed to parse blocksize argument"));
-                       if (blksize <= 0)
-                               usage(MKFS_USAGE);
+               {
+                       long long tmp = strtoll_or_err(optarg,
+                                       _("failed to parse blocksize argument"));
+
+                       if (tmp <= 0 || UINT_MAX < tmp)
+                               errx(MKFS_USAGE, _("invalid block size"));
+                       blksize = tmp;
                        break;
+               }
                case 'E':
                        opt_errors = 1;
                        break;