net: stmmac: simplify GSO/TSO test in stmmac_xmit()

The test in stmmac_xmit() to see whether we should pass the skbuff to
stmmac_tso_xmit() is more complex than it needs to be. This test can
be simplified by storing the mask of GSO types that we will pass, and
setting it according to the enabled features.

Note that "tso" is a mis-nomer since commit b776620651a1 ("net:
stmmac: Implement UDP Segmentation Offload"). Also note that this
commit controls both via the TSO feature. We preserve this behaviour
in this commit.

Also, this commit unconditionally accessed skb_shinfo(skb)->gso_type
for all frames, even when skb_is_gso() was false. This access is
eliminated.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1w7ptj-0000000Eatb-11zK@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
index 919a93a5239039431cdb48230788c3e81eb13abc..8ba8f03e1ce037a59e8ead33971d7bc3c84286c5 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
@@ -265,8 +265,9 @@ struct stmmac_priv {
        u32 rx_coal_frames[MTL_MAX_RX_QUEUES];
 
        int hwts_tx_en;
+       /* skb_shinfo(skb)->gso_type types that we handle */
+       unsigned int gso_enabled_types;
        bool tx_path_in_lpi_mode;
-       bool tso;
        bool sph_active;
        bool sph_capable;
        u32 sarc_type;

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index e88107a0baf28a93270ebf40c406205bf79d6276..72180c749add4d1a80a1315b351c53e12eb2bc63 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4373,6 +4373,18 @@ static void stmmac_flush_tx_descriptors(struct stmmac_priv *priv, int queue)
        stmmac_set_queue_tx_tail_ptr(priv, tx_q, queue, tx_q->cur_tx);
 }
 
+static void stmmac_set_gso_types(struct stmmac_priv *priv, bool tso)
+{
+       if (!tso) {
+               priv->gso_enabled_types = 0;
+       } else {
+               /* Manage oversized TCP frames for GMAC4 device */
+               priv->gso_enabled_types = SKB_GSO_TCPV4 | SKB_GSO_TCPV6;
+               if (priv->plat->core_type == DWMAC_CORE_GMAC4)
+                       priv->gso_enabled_types |= SKB_GSO_UDP_L4;
+       }
+}
+
 static size_t stmmac_tso_header_size(struct sk_buff *skb)
 {
        size_t size;
@@ -4706,7 +4718,6 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
        u32 queue = skb_get_queue_mapping(skb);
        int nfrags = skb_shinfo(skb)->nr_frags;
        unsigned int first_entry, tx_packets;
-       int gso = skb_shinfo(skb)->gso_type;
        struct stmmac_txq_stats *txq_stats;
        struct dma_desc *desc, *first_desc;
        struct stmmac_tx_queue *tx_q;
@@ -4718,14 +4729,9 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
        if (priv->tx_path_in_lpi_mode && priv->eee_sw_timer_en)
                stmmac_stop_sw_lpi(priv);
 
-       /* Manage oversized TCP frames for GMAC4 device */
-       if (skb_is_gso(skb) && priv->tso) {
-               if (gso & (SKB_GSO_TCPV4 | SKB_GSO_TCPV6))
-                       return stmmac_tso_xmit(skb, dev);
-               if (priv->plat->core_type == DWMAC_CORE_GMAC4 &&
-                   (gso & SKB_GSO_UDP_L4))
-                       return stmmac_tso_xmit(skb, dev);
-       }
+       if (skb_is_gso(skb) &&
+           skb_shinfo(skb)->gso_type & priv->gso_enabled_types)
+               return stmmac_tso_xmit(skb, dev);
 
        if (priv->est && priv->est->enable &&
            priv->est->max_sdu[queue]) {
@@ -6151,7 +6157,7 @@ static int stmmac_set_features(struct net_device *netdev,
                        stmmac_enable_sph(priv, priv->ioaddr, sph_en, chan);
        }
 
-       priv->tso = !!(features & NETIF_F_TSO);
+       stmmac_set_gso_types(priv, features & NETIF_F_TSO);
 
        if (features & NETIF_F_HW_VLAN_CTAG_RX)
                priv->hw->hw_vlan_en = true;
@@ -7880,7 +7886,7 @@ static int __stmmac_dvr_probe(struct device *device,
                ndev->hw_features |= NETIF_F_TSO | NETIF_F_TSO6;
                if (priv->plat->core_type == DWMAC_CORE_GMAC4)
                        ndev->hw_features |= NETIF_F_GSO_UDP_L4;
-               priv->tso = true;
+               stmmac_set_gso_types(priv, true);
                dev_info(priv->device, "TSO feature enabled\n");
        }