]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
smb: do not test the return value of folio_start_writeback()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Wed, 8 Nov 2023 20:46:04 +0000 (20:46 +0000)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:57 +0000 (18:19 -0400)
[ Upstream commit a9540e35624d1475f47dbf6353eed8b99936d36e ]

In preparation for removing the return value entirely, stop testing it
in smb.

Link: https://lkml.kernel.org/r/20231108204605.745109-4-willy@infradead.org
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Steve French <sfrench@samba.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Stable-dep-of: f3dc1bdb6b0b ("cifs: Fix writeback data corruption")
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/file.c

index 4cbb5487bd8d09d22991d74f973a7abeb0b8568b..043bee4020a91eb357f0b7c9c3472dc21bc7854c 100644 (file)
@@ -2709,8 +2709,7 @@ static void cifs_extend_writeback(struct address_space *mapping,
                         */
                        if (!folio_clear_dirty_for_io(folio))
                                WARN_ON(1);
-                       if (folio_start_writeback(folio))
-                               WARN_ON(1);
+                       folio_start_writeback(folio);
 
                        *_count -= folio_nr_pages(folio);
                        folio_unlock(folio);
@@ -2745,8 +2744,7 @@ static ssize_t cifs_write_back_from_locked_folio(struct address_space *mapping,
        int rc;
 
        /* The folio should be locked, dirty and not undergoing writeback. */
-       if (folio_start_writeback(folio))
-               WARN_ON(1);
+       folio_start_writeback(folio);
 
        count -= folio_nr_pages(folio);
        len = folio_size(folio);