First part of bugfix for #5933

Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().

Jeremy, please check!
(cherry picked from commit 769989008d97308d2a10675a91ae2dfdde493bab)

diff --git a/source/smbd/password.c b/source/smbd/password.c
index 1d3514429f33d5c74d3aae06dc12b93b5c841b97..54f30687734c54348a4d98d4ec706b8c7027162e 100644 (file)
--- a/source/smbd/password.c
+++ b/source/smbd/password.c
@@ -292,9 +292,6 @@ int register_existing_vuid(uint16 vuid,
                "and will be vuid %u\n", (int)vuser->server_info->utok.uid,
                 vuser->server_info->unix_name, vuser->vuid));
 
-       next_vuid++;
-       num_validated_vuids++;
-
        if (!session_claim(vuser)) {
                DEBUG(1, ("register_existing_vuid: Failed to claim session "
                        "for vuid=%d\n",