]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/msm/dp: fix HPD state status bit shift value
authorJessica Zhang <jessica.zhang@oss.qualcomm.com>
Sun, 24 May 2026 10:33:29 +0000 (13:33 +0300)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Fri, 29 May 2026 11:58:51 +0000 (14:58 +0300)
The HPD state status is the 3 most significant bits, not 4 bits of the
HPD_INT_STATUS register.

Fix the bit shift macro so that the correct bits are returned in
msm_dp_aux_is_link_connected().

Fixes: 19e52bcb27c2 ("drm/msm/dp: return correct connection status after suspend")
Signed-off-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: Val Packett <val@packett.cool> # x1e80100-dell-latitude-7455
Tested-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com> # Hamoa IOT EVK, QCS8300 Ride
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/727611/
Link: https://lore.kernel.org/r/20260524-hpd-refactor-v6-1-cf3ab488dd7b@oss.qualcomm.com
drivers/gpu/drm/msm/dp/dp_reg.h

index 7c44d4e2cf13960b5ab3277b1581ebbd539d4f65..3689642b7fc061aac720e143f39811b9f38d673d 100644 (file)
@@ -68,8 +68,8 @@
 #define DP_DP_IRQ_HPD_INT_ACK                  (0x00000002)
 #define DP_DP_HPD_REPLUG_INT_ACK               (0x00000004)
 #define DP_DP_HPD_UNPLUG_INT_ACK               (0x00000008)
-#define DP_DP_HPD_STATE_STATUS_BITS_MASK       (0x0000000F)
-#define DP_DP_HPD_STATE_STATUS_BITS_SHIFT      (0x1C)
+#define DP_DP_HPD_STATE_STATUS_BITS_MASK       (0x00000007)
+#define DP_DP_HPD_STATE_STATUS_BITS_SHIFT      (0x1D)
 
 #define REG_DP_DP_HPD_INT_MASK                 (0x0000000C)
 #define DP_DP_HPD_PLUG_INT_MASK                        (0x00000001)