]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
rpc: socket: properly call virSetCloseExec
authorJán Tomko <jtomko@redhat.com>
Tue, 22 Sep 2020 20:29:25 +0000 (22:29 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 23 Sep 2020 11:26:34 +0000 (13:26 +0200)
cppcheck reports:
style: Argument 'fd<0' to function virSetCloseExec is always 0 [knownArgument]

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Fixes: 4b9919af4024a6fbc3d4ee996d8a4c27dbc44285
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/rpc/virnetsocket.c

index ebdeadc4a0a790cb1c3f8926888767e37f56e10a..f79a638775b9962cf5e8a3f7fcc61d07bd56c2a6 100644 (file)
@@ -1388,7 +1388,7 @@ int virNetSocketDupFD(virNetSocketPtr sock, bool cloexec)
     }
 #ifndef F_DUPFD_CLOEXEC
     if (cloexec &&
-        virSetCloseExec(fd < 0)) {
+        virSetCloseExec(fd) < 0) {
         int saveerr = errno;
         closesocket(fd);
         errno = saveerr;