]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
eve/tls: remove broken check for ja3 being enabled
authorJason Ish <jason.ish@oisf.net>
Thu, 17 Oct 2024 14:41:54 +0000 (08:41 -0600)
committerVictor Julien <victor@inliniac.net>
Mon, 21 Oct 2024 18:19:27 +0000 (20:19 +0200)
During EVE TLS setup, a broken check for Ja3 being enabled led to Ja3
being disabled, but only in custom mode. This check is not needed, if
Ja3 is disabled, it won't be available, and won't be logged.

This is required to implement "extended" in terms of "custom" fields.

src/output-json-tls.c

index b58503a661003987d77096c4cdb1ea972aeb2b35..03108cf6477f044caca18ed895a6f6a94850b88a 100644 (file)
@@ -663,13 +663,6 @@ static OutputTlsCtx *OutputTlsInitCtx(ConfNode *conf)
         tls_ctx->flags |= LOG_TLS_SESSION_RESUMPTION;
     }
 
-    if ((tls_ctx->fields & LOG_TLS_FIELD_JA3) &&
-            Ja3IsDisabled("fields")) {
-        /* JA3 is disabled, so don't log any JA3 fields */
-        tls_ctx->fields &= ~LOG_TLS_FIELD_JA3;
-        tls_ctx->fields &= ~LOG_TLS_FIELD_JA3S;
-    }
-
     if ((tls_ctx->fields & LOG_TLS_FIELD_CERTIFICATE) &&
             (tls_ctx->fields & LOG_TLS_FIELD_CHAIN)) {
         SCLogWarning("Both 'certificate' and 'chain' contains the top "