]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4-echo: Remove the "echo" server (port 7, RFC 862) in production builds
authorAndrew Bartlett <abartlet@samba.org>
Tue, 12 Sep 2023 07:03:10 +0000 (19:03 +1200)
committerJule Anger <janger@samba.org>
Tue, 10 Oct 2023 14:49:40 +0000 (14:49 +0000)
This demonstration should never be enabled in production, if
echo service is required other software is far better positioned
to provide it.  Reflection attacks on echo are a known issue.

This is removed for consistency with the removal of rpcecho, but was
never enabled in the default smb.conf so is mostly harmless.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
source4/echo_server/wscript_build

index 8c40ec8c418ac0b34552af03e0721870fe06b27d..3d70f0c397a43c694dcae6ccc13a81830e3806d1 100644 (file)
@@ -6,5 +6,5 @@ bld.SAMBA_MODULE('ECHO',
         init_function='server_service_echo_init',
         deps='samba-hostconfig LIBTSOCKET LIBSAMBA_TSOCKET',
         local_include=False,
-        enabled=bld.AD_DC_BUILD_IS_ENABLED()
+        enabled=bld.CONFIG_GET('ENABLE_SELFTEST'),
         )