Bug 347707: Changing parameters could silently fail because we weren't correctly

 checking the return code from "rename"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index 428c13fe51fed2faa99717b52481a94507844d82..619eb05a886c0f935a317641235b69f52fbcd662 100644 (file)
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -279,7 +279,7 @@ sub write_params {
     close $fh;
 
     rename $tmpname, $param_file
-      || die "Can't rename $tmpname to $param_file: $!";
+      or die "Can't rename $tmpname to $param_file: $!";
 
     ChmodDataFile($param_file, 0666);