Merged revisions 273144 via svnmerge from

https://origsvn.digium.com/svn/asterisk/trunk

........
  r273144 | tilghman | 2010-06-29 20:07:02 -0500 (Tue, 29 Jun 2010) | 8 lines

  Permission checking for the system application is backwards.

  (closes issue #17550)
   Reported by: kenner
   Patches:
         manager.c.diff uploaded by kenner (license 1040)
   Tested by: kenner
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@273145 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/main/manager.c b/main/manager.c
index faa6538e4251b9ba35171f415568b0a81022ef8c..5bbeec0fca477b9d5ebf87721456e000ca0ab7a2 100644 (file)
--- a/main/manager.c
+++ b/main/manager.c
@@ -2523,7 +2523,7 @@ static int action_originate(struct mansession *s, const struct message *m)
                /* To run the System application (or anything else that goes to shell), you must have the additional System privilege */
                if (!(s->session->writeperm & EVENT_FLAG_SYSTEM)
                        && (
-                               strcasestr(app, "system") == 0 || /* System(rm -rf /)
+                               strcasestr(app, "system") ||      /* System(rm -rf /)
                                                                     TrySystem(rm -rf /)       */
                                strcasestr(app, "exec") ||        /* Exec(System(rm -rf /))
                                                                     TryExec(System(rm -rf /)) */