]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SDCA: Add missing default in switch in entity_pde_event()
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Tue, 24 Jun 2025 12:28:39 +0000 (13:28 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 30 Jun 2025 15:04:13 +0000 (16:04 +0100)
The current code should be safe as the PDE widget only registers for the
two events handled in the switch statement. However, it is causing a
smatch warning and also is a little fragile to future code changes, add
a default case to avoid the warning and make the code more robust.

Fixes: 2c8b3a8e6aa8 ("ASoC: SDCA: Create DAPM widgets and routes from DisCo")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Link: https://patch.msgid.link/20250624122844.2761627-3-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdca/sdca_asoc.c

index 7bc8f6069f3d41f253907c90456ea1cf40406355..e96e696cb1079afdf5bdc7faa00e41d331a39ece 100644 (file)
@@ -397,6 +397,8 @@ static int entity_pde_event(struct snd_soc_dapm_widget *widget,
                from = widget->off_val;
                to = widget->on_val;
                break;
+       default:
+               return 0;
        }
 
        for (i = 0; i < entity->pde.num_max_delay; i++) {