]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix isc_nm_listentlsdns() error path bug
authorAram Sargsyan <aram@isc.org>
Mon, 5 Sep 2022 14:42:32 +0000 (14:42 +0000)
committerAram Sargsyan <aram@isc.org>
Mon, 5 Sep 2022 14:58:52 +0000 (14:58 +0000)
The isc_nm_listentlsdns() function erroneously calls
isc__nm_tcpdns_stoplistening() instead of isc__nm_tlsdns_stoplistening()
when something goes wrong, which can cause an assertion failure.

lib/isc/netmgr/tlsdns.c

index a4ae9755e6e7b4c75b2914472bf47f5f6903693f..3ad86a39793ca8e140190177e54089a3432805b7 100644 (file)
@@ -542,7 +542,7 @@ isc_nm_listentlsdns(isc_nm_t *mgr, uint32_t workers, isc_sockaddr_t *iface,
 
        if (result != ISC_R_SUCCESS) {
                atomic_store(&sock->active, false);
-               isc__nm_tcpdns_stoplistening(sock);
+               isc__nm_tlsdns_stoplistening(sock);
                isc_nmsocket_close(&sock);
 
                return (result);