]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
soc: qcom: rpmh-rsc: Unconditionally clear _TRIGGER bit for TCS
authorSneh Mankad <sneh.mankad@oss.qualcomm.com>
Mon, 25 Aug 2025 06:23:50 +0000 (11:53 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Oct 2025 09:56:26 +0000 (11:56 +0200)
[ Upstream commit f87412d18edb5b8393eb8cb1c2d4a54f90185a21 ]

Unconditionally clear the TCS_AMC_MODE_TRIGGER bit when a
transaction completes. Previously this bit was only cleared when
a wake TCS was borrowed as an AMC TCS but not for dedicated
AMC TCS. Leaving this bit set for AMC TCS and entering deeper low
power modes can generate a false completion IRQ.

Prevent this scenario by always clearing the TCS_AMC_MODE_TRIGGER
bit upon receiving a completion IRQ.

Fixes: 15b3bf61b8d4 ("soc: qcom: rpmh-rsc: Clear active mode configuration for wake TCS")
Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250825-rpmh_rsc_change-v1-1-138202c31bf6@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/qcom/rpmh-rsc.c

index ff2b9eb9f669f4a3326c0f2b457dfc53f4a5b3ed..5797d9570541768c4aa9820a76c0956844f4c723 100644 (file)
@@ -415,13 +415,10 @@ static irqreturn_t tcs_tx_done(int irq, void *p)
 
                trace_rpmh_tx_done(drv, i, req, err);
 
-               /*
-                * If wake tcs was re-purposed for sending active
-                * votes, clear AMC trigger & enable modes and
+               /* Clear AMC trigger & enable modes and
                 * disable interrupt for this TCS
                 */
-               if (!drv->tcs[ACTIVE_TCS].num_tcs)
-                       __tcs_set_trigger(drv, i, false);
+               __tcs_set_trigger(drv, i, false);
 skip:
                /* Reclaim the TCS */
                write_tcs_reg(drv, RSC_DRV_CMD_ENABLE, i, 0);