]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
exfat: fdatasync flag should be same like generic_write_sync()
authorZhengxu Zhang <zhengxu.zhang@unisoc.com>
Thu, 19 Jun 2025 01:33:31 +0000 (09:33 +0800)
committerNamjae Jeon <linkinjeon@kernel.org>
Thu, 31 Jul 2025 23:34:17 +0000 (08:34 +0900)
Test: androbench by default setting, use 64GB sdcard.
 the random write speed:
without this patch 3.5MB/s
with this patch 7MB/s

After patch "11a347fb6cef", the random write speed decreased significantly.
the .write_iter() interface had been modified, and check the differences
with generic_file_write_iter(), when calling generic_write_sync() and
exfat_file_write_iter() to call vfs_fsync_range(), the fdatasync flag is
wrong, and make not use the fdatasync mode, and make random write speed
decreased. So use generic_write_sync() instead of vfs_fsync_range().

Fixes: 11a347fb6cef ("exfat: change to get file size from DataLength")
Signed-off-by: Zhengxu Zhang <zhengxu.zhang@unisoc.com>
Acked-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
fs/exfat/file.c

index 6b82497572b4c51854125130eb4b989ca2502816..538d2b6ac2ecaffb1790c04437da1827e0f3eeb0 100644 (file)
@@ -622,9 +622,8 @@ static ssize_t exfat_file_write_iter(struct kiocb *iocb, struct iov_iter *iter)
        if (pos > valid_size)
                pos = valid_size;
 
-       if (iocb_is_dsync(iocb) && iocb->ki_pos > pos) {
-               ssize_t err = vfs_fsync_range(file, pos, iocb->ki_pos - 1,
-                               iocb->ki_flags & IOCB_SYNC);
+       if (iocb->ki_pos > pos) {
+               ssize_t err = generic_write_sync(iocb, iocb->ki_pos - pos);
                if (err < 0)
                        return err;
        }