]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: aspeed: Use devm_iounmap() to unmap devm_ioremap() memory
authorChin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Wed, 5 Nov 2025 08:49:52 +0000 (16:49 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 5 Nov 2025 11:56:27 +0000 (11:56 +0000)
The AHB IO memory for each chip select is mapped using
devm_ioremap(), so it should be unmapped using devm_iounmap()
to ensure proper device-managed resource cleanup.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510292356.JnTUBxCl-lkp@intel.com/
Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://patch.msgid.link/20251105084952.1063489-1-chin-ting_kuo@aspeedtech.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-aspeed-smc.c

index e8bd8fe6c4e77da301932ce93e12e8430d0e377d..179c47ffbfeb12cf7c848a2df3293d0577759792 100644 (file)
@@ -396,7 +396,7 @@ static int aspeed_spi_set_window(struct aspeed_spi *aspi)
 
        for (cs = 0; cs < aspi->data->max_cs; cs++) {
                if (aspi->chips[cs].ahb_base) {
-                       iounmap(aspi->chips[cs].ahb_base);
+                       devm_iounmap(dev, aspi->chips[cs].ahb_base);
                        aspi->chips[cs].ahb_base = NULL;
                }
        }