]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: acme: does not try to unlock after a failed trylock
authorWilliam Lallemand <wlallemand@haproxy.com>
Tue, 29 Apr 2025 09:29:52 +0000 (11:29 +0200)
committerWilliam Lallemand <wlallemand@haproxy.com>
Tue, 29 Apr 2025 09:29:52 +0000 (11:29 +0200)
Return after a failed trylock in acme_update_certificate() instead of
jumping to the error label which does an unlock.

src/acme.c

index 13241a745acae00b129df8f38aeaa8a78e66e364..45d701409fcce2e3fd1c95273978668bb3d42063 100644 (file)
@@ -706,8 +706,7 @@ int acme_update_certificate(struct task *task, struct acme_ctx *ctx, char **errm
 
        if (HA_SPIN_TRYLOCK(CKCH_LOCK, &ckch_lock)) {
                memprintf(errmsg, "couldn't get the certificate lock!");
-               goto error;
-
+               return ret;
        }
 
        if ((old_ckchs = ckchs_lookup(new_ckchs->path)) == NULL) {