]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
samba-tool processes: Remove unused loop
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 5 May 2022 08:41:26 +0000 (20:41 +1200)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 10 May 2022 05:19:34 +0000 (05:19 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
python/samba/netcmd/processes.py

index 09b8529448c7c4f14b3648452e7424675949f797..12a05a69329c46b57e65ae94a18415fdfe883b66 100644 (file)
@@ -68,21 +68,20 @@ class cmd_processes(Command):
         masters = {}
         workers = {}
         for service in services:
-            for id in service.ids:
-                if service.name.startswith("prefork-master"):
-                    ns = service.name.split("-")
-                    name = ns[2] + "_server"
-                    masters[name] = service.ids[0].pid
-                elif service.name.startswith("prefork-worker"):
-                    ns = service.name.split("-")
-                    name = ns[2] + "_server"
-                    instance = int(ns[3])
-                    pid = service.ids[0].pid
-                    if name not in workers:
-                        workers[name] = {}
-                    workers[name][instance] = (instance, pid)
-                else:
-                    filtered.append(service)
+            if service.name.startswith("prefork-master"):
+                ns = service.name.split("-")
+                name = ns[2] + "_server"
+                masters[name] = service.ids[0].pid
+            elif service.name.startswith("prefork-worker"):
+                ns = service.name.split("-")
+                name = ns[2] + "_server"
+                instance = int(ns[3])
+                pid = service.ids[0].pid
+                if name not in workers:
+                    workers[name] = {}
+                workers[name][instance] = (instance, pid)
+            else:
+                filtered.append(service)
         return (filtered, masters, workers)
 
     def run(self, sambaopts, versionopts, section_name=None,