]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
DER decoder: don't use strlcpy on non-strings
authorVictor Julien <victor@inliniac.net>
Thu, 17 Dec 2015 12:25:02 +0000 (13:25 +0100)
committerVictor Julien <victor@inliniac.net>
Thu, 17 Dec 2015 12:25:02 +0000 (13:25 +0100)
src/util-decode-der.c

index 1687668bd5fd8abebdb91589f5cef40945e6194c..05c4671ad853fd3d5a1cebe694d67ef9cb97f6d8 100644 (file)
@@ -482,7 +482,8 @@ static Asn1Generic * DecodeAsn1DerIA5String(const unsigned char *buffer, uint32_
         SCFree(a);
         return NULL;
     }
-    strlcpy(a->str, (const char*)d_ptr, length+1);
+    memcpy(a->str, (const char*)d_ptr, length);
+    a->str[length] = 0;
 
     d_ptr += length;
 
@@ -583,8 +584,8 @@ static Asn1Generic * DecodeAsn1DerPrintableString(const unsigned char *buffer, u
         SCFree(a);
         return NULL;
     }
-    strlcpy(a->str, (const char*)d_ptr, length+1);
-    a->str[length] = '\0';
+    memcpy(a->str, (const char*)d_ptr, length);
+    a->str[length] = 0;
 
     d_ptr += length;