libsoup: fix CVE-2025-4969

Refer:
https://gitlab.gnome.org/GNOME/libsoup/-/issues/447

Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>

diff --git a/meta/recipes-support/libsoup/libsoup/CVE-2025-4969.patch b/meta/recipes-support/libsoup/libsoup/CVE-2025-4969.patch
new file mode 100644 (file)
index 0000000..97702a3
--- /dev/null
+++ b/meta/recipes-support/libsoup/libsoup/CVE-2025-4969.patch
@@ -0,0 +1,78 @@
+From e8ef88ed86929c9a0dc343a4c7d29a8f2bcf400f Mon Sep 17 00:00:00 2001
+From: Milan Crha <mcrha@redhat.com>
+Date: Mon, 19 May 2025 17:48:27 +0200
+Subject: [PATCH] soup-multipart: Verify array bounds before accessing its
+ members
+
+The boundary could be at a place which, calculated, pointed
+before the beginning of the array. Check the bounds, to avoid
+read out of the array bounds.
+
+Closes https://gitlab.gnome.org/GNOME/libsoup/-/issues/447
+
+CVE: CVE-2025-4969
+Upstream-Status: Backport
+[https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/467/commits]
+
+Signed-off-by: Changqing Li <changqing.li@windriver.com>
+---
+ libsoup/soup-multipart.c |  2 +-
+ tests/multipart-test.c   | 22 ++++++++++++++++++++++
+ 2 files changed, 23 insertions(+), 1 deletion(-)
+
+diff --git a/libsoup/soup-multipart.c b/libsoup/soup-multipart.c
+index a587fe7..27257e4 100644
+--- a/libsoup/soup-multipart.c
++++ b/libsoup/soup-multipart.c
+@@ -104,7 +104,7 @@ find_boundary (const char *start, const char *end,
+                       continue;
+ 
+               /* Check that it's at start of line */
+-              if (!(b == start || (b[-1] == '\n' && b[-2] == '\r')))
++              if (!(b == start || (b - start >= 2 && b[-1] == '\n' && b[-2] == '\r')))
+                       continue;
+ 
+               /* Check for "--" or "\r\n" after boundary */
+diff --git a/tests/multipart-test.c b/tests/multipart-test.c
+index 92b673e..3792563 100644
+--- a/tests/multipart-test.c
++++ b/tests/multipart-test.c
+@@ -527,6 +527,27 @@ test_multipart_bounds_bad (void)
+       g_bytes_unref (bytes);
+ }
+ 
++static void
++test_multipart_bounds_bad_2 (void)
++{
++      SoupMultipart *multipart;
++      SoupMessageHeaders *headers;
++      GBytes *bytes;
++      const char *raw_data = "\n--123\r\nline\r\n--123--\r";
++
++      headers = soup_message_headers_new (SOUP_MESSAGE_HEADERS_MULTIPART);
++      soup_message_headers_append (headers, "Content-Type", "multipart/mixed; boundary=\"123\"");
++
++      bytes = g_bytes_new (raw_data, strlen (raw_data));
++
++      multipart = soup_multipart_new_from_message (headers, bytes);
++      g_assert_nonnull (multipart);
++
++      soup_multipart_free (multipart);
++      soup_message_headers_unref (headers);
++      g_bytes_unref (bytes);
++}
++
+ static void
+ test_multipart_too_large (void)
+ {
+@@ -595,6 +616,7 @@ main (int argc, char **argv)
+       g_test_add_data_func ("/multipart/async-small-reads", GINT_TO_POINTER (ASYNC_MULTIPART_SMALL_READS), test_multipart);
+       g_test_add_func ("/multipart/bounds-good", test_multipart_bounds_good);
+       g_test_add_func ("/multipart/bounds-bad", test_multipart_bounds_bad);
++      g_test_add_func ("/multipart/bounds-bad-2", test_multipart_bounds_bad_2);
+       g_test_add_func ("/multipart/too-large", test_multipart_too_large);
+ 
+       ret = g_test_run ();
+-- 
+2.34.1
+

diff --git a/meta/recipes-support/libsoup/libsoup_3.6.5.bb b/meta/recipes-support/libsoup/libsoup_3.6.5.bb
index 772e21e09b7aea0811750a0af8d311964270a6a0..457a30ec70638234c60cea042eb9d3d673d18ab9 100644 (file)
--- a/meta/recipes-support/libsoup/libsoup_3.6.5.bb
+++ b/meta/recipes-support/libsoup/libsoup_3.6.5.bb
@@ -19,6 +19,7 @@ SRC_URI = "${GNOME_MIRROR}/libsoup/${SHRT_VER}/libsoup-${PV}.tar.xz \
            file://CVE-2025-32908-1.patch \
            file://CVE-2025-32908-2.patch \
            file://CVE-2025-4948.patch \
+           file://CVE-2025-4969.patch \
 "
 SRC_URI[sha256sum] = "6891765aac3e949017945c3eaebd8cc8216df772456dc9f460976fbdb7ada234"