]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: qgroup: remove pointless error check for add_qgroup_rb() call
authorFilipe Manana <fdmanana@suse.com>
Wed, 25 Jun 2025 15:16:05 +0000 (16:16 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 21 Jul 2025 21:58:04 +0000 (23:58 +0200)
The add_qgroup_rb() function never returns an error pointer anymore since
commit 8d54518b5e52 ("btrfs: qgroup: pre-allocate btrfs_qgroup to reduce
GFP_ATOMIC usage"), so checking for an error pointer result at
btrfs_quota_enable() is pointless.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c

index e38272ac808d9090c45c0cd8a943a602b42c6791..afc9a27071298f32d3581d09eac6e150220da1ba 100644 (file)
@@ -1161,11 +1161,6 @@ int btrfs_quota_enable(struct btrfs_fs_info *fs_info,
 
                        qgroup = add_qgroup_rb(fs_info, prealloc, found_key.offset);
                        prealloc = NULL;
-                       if (IS_ERR(qgroup)) {
-                               ret = PTR_ERR(qgroup);
-                               btrfs_abort_transaction(trans, ret);
-                               goto out_free_path;
-                       }
                        ret = btrfs_sysfs_add_one_qgroup(fs_info, qgroup);
                        if (ret < 0) {
                                btrfs_abort_transaction(trans, ret);