]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: exynos5-usbdrd: support SS combo phy for ExynosAutov920
authorPritam Manohar Sutar <pritam.sutar@samsung.com>
Mon, 24 Nov 2025 11:04:53 +0000 (16:34 +0530)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Dec 2025 17:41:05 +0000 (23:11 +0530)
Update phy driver to enable SS combo phy for this SoC. New registers'
definitions, phy ops (init/exit), and dedicated phy driver data
structure are added for SS combo phy. Add these changes in the driver
to support SS combo phy for this SoC.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
Link: https://patch.msgid.link/20251124110453.2887437-7-pritam.sutar@samsung.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/samsung/phy-exynos5-usbdrd.c
include/linux/soc/samsung/exynos-regs-pmu.h

index 5bbf78d44a74c2afb37aa519d5f6ac81177431f8..5a181cb4597e9c4072e05ae7a218166226276b2b 100644 (file)
 #define EXYNOSAUTOV920_DRD_HSPPLLTUNE          0x110
 #define HSPPLLTUNE_FSEL                                GENMASK(18, 16)
 
+/* ExynosAutov920 phy usb31drd port reg */
+#define EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL   0x000
+#define PHY_RST_CTRL_PIPE_LANE0_RESET_N_OVRD_EN        BIT(5)
+#define PHY_RST_CTRL_PIPE_LANE0_RESET_N                BIT(4)
+#define PHY_RST_CTRL_PHY_RESET_OVRD_EN         BIT(1)
+#define PHY_RST_CTRL_PHY_RESET                 BIT(0)
+
+#define EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0       0x0004
+#define PHY_CR_PARA_CON0_PHY0_CR_PARA_ADDR             GENMASK(31, 16)
+#define PHY_CR_PARA_CON0_PHY0_CR_PARA_CLK              BIT(8)
+#define PHY_CR_PARA_CON0_PHY0_CR_PARA_ACK              BIT(4)
+#define PHY_CR_PARA_CON0_PHY0_CR_PARA_SEL              BIT(0)
+
+#define EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON1       0x0008
+
+#define EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON2       0x000c
+#define PHY_CR_PARA_CON2_PHY0_CR_PARA_WR_EN            BIT(0)
+#define PHY_CR_PARA_CON2_PHY0_CR_PARA_WR_DATA          GENMASK(31, 16)
+
+#define EXYNOSAUTOV920_USB31DRD_PHY_CONFIG0    0x100
+#define PHY_CONFIG0_PHY0_PMA_PWR_STABLE                BIT(14)
+#define PHY_CONFIG0_PHY0_PCS_PWR_STABLE                BIT(13)
+#define PHY_CONFIG0_PHY0_ANA_PWR_EN            BIT(1)
+
+#define EXYNOSAUTOV920_USB31DRD_PHY_CONFIG7    0x11c
+#define PHY_CONFIG7_PHY_TEST_POWERDOWN         BIT(24)
+
+#define EXYNOSAUTOV920_USB31DRD_PHY_CONFIG4    0x110
+#define PHY_CONFIG4_PIPE_RX0_SRIS_MODE_EN      BIT(2)
+
 /* Exynos9 - GS101 */
 #define EXYNOS850_DRD_SECPMACTL                        0x48
 #define SECPMACTL_PMA_ROPLL_REF_CLK_SEL                GENMASK(13, 12)
@@ -2077,6 +2107,251 @@ static const struct exynos5_usbdrd_phy_drvdata exynos990_usbdrd_phy = {
        .n_regulators           = ARRAY_SIZE(exynos5_regulator_names),
 };
 
+static void
+exynosautov920_usb31drd_cr_clk(struct exynos5_usbdrd_phy *phy_drd, bool high)
+{
+       void __iomem *reg_phy = phy_drd->reg_phy;
+       u32 reg;
+
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+       if (high)
+               reg |= PHY_CR_PARA_CON0_PHY0_CR_PARA_CLK;
+       else
+               reg &= ~PHY_CR_PARA_CON0_PHY0_CR_PARA_CLK;
+
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+       fsleep(1);
+}
+
+static void
+exynosautov920_usb31drd_port_phy_ready(struct exynos5_usbdrd_phy *phy_drd)
+{
+       struct device *dev = phy_drd->dev;
+       void __iomem *reg_phy = phy_drd->reg_phy;
+       static const unsigned int timeout_us = 20000;
+       static const unsigned int sleep_us = 40;
+       u32 reg;
+       int err;
+
+       /* Clear cr_para_con */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+       reg &= ~(PHY_CR_PARA_CON0_PHY0_CR_PARA_CLK |
+                       PHY_CR_PARA_CON0_PHY0_CR_PARA_ADDR);
+       reg |= PHY_CR_PARA_CON0_PHY0_CR_PARA_SEL;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+       writel(0x0, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON1);
+       writel(0x0, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON2);
+
+       exynosautov920_usb31drd_cr_clk(phy_drd, true);
+       exynosautov920_usb31drd_cr_clk(phy_drd, false);
+
+       /*
+        * The maximum time from phy reset de-assertion to de-assertion of
+        * tx/rx_ack can be as high as 5ms in fast simulation mode.
+        * Time to phy ready is < 20ms
+        */
+       err = readl_poll_timeout(reg_phy +
+                               EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0,
+                       reg, !(reg & PHY_CR_PARA_CON0_PHY0_CR_PARA_ACK),
+                       sleep_us, timeout_us);
+       if (err)
+               dev_err(dev, "timed out waiting for rx/tx_ack: %#.8x\n", reg);
+
+       reg &= ~PHY_CR_PARA_CON0_PHY0_CR_PARA_CLK;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+}
+
+static void
+exynosautov920_usb31drd_cr_write(struct exynos5_usbdrd_phy *phy_drd,
+                                u16 addr, u16 data)
+{
+       void __iomem *reg_phy = phy_drd->reg_phy;
+       u32 cnt = 0;
+       u32 reg;
+
+       /* Pre Clocking */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+       reg |= PHY_CR_PARA_CON0_PHY0_CR_PARA_SEL;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+
+       /*
+        * tx clks must be available prior to assertion of tx req.
+        * tx pstate p2 to p0 transition directly is not permitted.
+        * tx clk ready must be asserted synchronously on tx clk prior
+        * to internal transmit clk alignment sequence in the phy
+        * when entering from p2 to p1 to p0.
+        */
+       do {
+               exynosautov920_usb31drd_cr_clk(phy_drd, true);
+               exynosautov920_usb31drd_cr_clk(phy_drd, false);
+               cnt++;
+       } while (cnt < 15);
+
+       reg &= ~PHY_CR_PARA_CON0_PHY0_CR_PARA_SEL;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+
+       /*
+        * tx data path is active when tx lane is in p0 state
+        * and tx data en asserted. enable cr_para_wr_en.
+        */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON2);
+       reg &= ~PHY_CR_PARA_CON2_PHY0_CR_PARA_WR_DATA;
+       reg |= FIELD_PREP(PHY_CR_PARA_CON2_PHY0_CR_PARA_WR_DATA, data) |
+               PHY_CR_PARA_CON2_PHY0_CR_PARA_WR_EN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON2);
+
+       /* write addr */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+       reg &= ~PHY_CR_PARA_CON0_PHY0_CR_PARA_ADDR;
+       reg |= FIELD_PREP(PHY_CR_PARA_CON0_PHY0_CR_PARA_ADDR, addr) |
+               PHY_CR_PARA_CON0_PHY0_CR_PARA_CLK |
+               PHY_CR_PARA_CON0_PHY0_CR_PARA_SEL;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+
+       /* check cr_para_ack*/
+       cnt = 0;
+       do {
+               /*
+                * data symbols are captured by phy on rising edge of the
+                * tx_clk when tx data enabled.
+                * completion of the write cycle is acknowledged by assertion
+                * of the cr_para_ack.
+                */
+               exynosautov920_usb31drd_cr_clk(phy_drd, true);
+               reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CR_PARA_CON0);
+               if ((reg & PHY_CR_PARA_CON0_PHY0_CR_PARA_ACK))
+                       break;
+
+               exynosautov920_usb31drd_cr_clk(phy_drd, false);
+
+               /*
+                * wait for minimum of 10 cr_para_clk cycles after phy reset
+                * is negated, before accessing control regs to allow for
+                * internal resets.
+                */
+               cnt++;
+       } while (cnt < 10);
+
+       if (cnt < 10)
+               exynosautov920_usb31drd_cr_clk(phy_drd, false);
+}
+
+static void
+exynosautov920_usb31drd_phy_reset(struct exynos5_usbdrd_phy *phy_drd, int val)
+{
+       void __iomem *reg_phy = phy_drd->reg_phy;
+       u32 reg;
+
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+       reg &= ~PHY_RST_CTRL_PHY_RESET_OVRD_EN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+       if (val)
+               reg |= PHY_RST_CTRL_PHY_RESET;
+       else
+               reg &= ~PHY_RST_CTRL_PHY_RESET;
+
+       reg |= PHY_RST_CTRL_PHY_RESET_OVRD_EN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+}
+
+static void
+exynosautov920_usb31drd_lane0_reset(struct exynos5_usbdrd_phy *phy_drd, int val)
+{
+       void __iomem *reg_phy = phy_drd->reg_phy;
+       u32 reg;
+
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+       reg |= PHY_RST_CTRL_PIPE_LANE0_RESET_N_OVRD_EN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+       if (val)
+               reg &= ~PHY_RST_CTRL_PIPE_LANE0_RESET_N;
+       else
+               reg |= PHY_RST_CTRL_PIPE_LANE0_RESET_N;
+
+       reg &= ~PHY_RST_CTRL_PIPE_LANE0_RESET_N_OVRD_EN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_RST_CTRL);
+}
+
+static void
+exynosautov920_usb31drd_pipe3_init(struct exynos5_usbdrd_phy *phy_drd)
+{
+       void __iomem *reg_phy = phy_drd->reg_phy;
+       u32 reg;
+
+       /*
+        * Phy and Pipe Lane reset assert.
+        * assert reset (phy_reset = 1).
+        * The lane-ack outputs are asserted during reset (tx_ack = rx_ack = 1)
+        */
+       exynosautov920_usb31drd_phy_reset(phy_drd, 1);
+       exynosautov920_usb31drd_lane0_reset(phy_drd, 1);
+
+       /*
+        * ANA Power En, PCS & PMA PWR Stable Set
+        * ramp-up power suppiles
+        */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG0);
+       reg |= PHY_CONFIG0_PHY0_ANA_PWR_EN | PHY_CONFIG0_PHY0_PCS_PWR_STABLE |
+               PHY_CONFIG0_PHY0_PMA_PWR_STABLE;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG0);
+
+       fsleep(10);
+
+       /*
+        * phy is not functional in test_powerdown mode, test_powerdown to be
+        * de-asserted for normal operation
+        */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG7);
+       reg &= ~PHY_CONFIG7_PHY_TEST_POWERDOWN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG7);
+
+       /*
+        * phy reset signal be asserted for minimum 10us after power
+        * supplies are ramped-up
+        */
+       fsleep(10);
+
+       /*
+        * Phy and Pipe Lane reset assert de-assert
+        */
+       exynosautov920_usb31drd_phy_reset(phy_drd, 0);
+       exynosautov920_usb31drd_lane0_reset(phy_drd, 0);
+
+       /* Pipe_rx0_sris_mode_en  = 1 */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG4);
+       reg |= PHY_CONFIG4_PIPE_RX0_SRIS_MODE_EN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG4);
+
+       /*
+        * wait for lane ack outputs to de-assert (tx_ack = rx_ack = 0)
+        * Exit from the reset state is indicated by de-assertion of *_ack
+        */
+       exynosautov920_usb31drd_port_phy_ready(phy_drd);
+
+       /* override values for level settings */
+       exynosautov920_usb31drd_cr_write(phy_drd, 0x22, 0x00F5);
+}
+
+static void
+exynosautov920_usb31drd_ssphy_disable(struct exynos5_usbdrd_phy *phy_drd)
+{
+       void __iomem *reg_phy = phy_drd->reg_phy;
+       u32 reg;
+
+       /* 1. Assert reset (phy_reset = 1) */
+       exynosautov920_usb31drd_lane0_reset(phy_drd, 1);
+       exynosautov920_usb31drd_phy_reset(phy_drd, 1);
+
+       /* phy test power down */
+       reg = readl(reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG7);
+       reg |= PHY_CONFIG7_PHY_TEST_POWERDOWN;
+       writel(reg, reg_phy + EXYNOSAUTOV920_USB31DRD_PHY_CONFIG7);
+}
+
 static void
 exynosautov920_usbdrd_utmi_init(struct exynos5_usbdrd_phy *phy_drd)
 {
@@ -2172,12 +2447,15 @@ exynosautov920_usbdrd_utmi_init(struct exynos5_usbdrd_phy *phy_drd)
        /* after POR low and delay 75us, PHYCLOCK is guaranteed. */
        fsleep(75);
 
-       /* force pipe3 signal for link */
+       /* Disable forcing pipe interface */
        reg = readl(reg_phy + EXYNOS850_DRD_LINKCTRL);
-       reg |= LINKCTRL_FORCE_PIPE_EN;
-       reg &= ~LINKCTRL_FORCE_PHYSTATUS;
-       reg |= LINKCTRL_FORCE_RXELECIDLE;
+       reg &= ~LINKCTRL_FORCE_PIPE_EN;
        writel(reg, reg_phy + EXYNOS850_DRD_LINKCTRL);
+
+       /* Pclk to pipe_clk */
+       reg = readl(reg_phy + EXYNOS2200_DRD_CLKRST);
+       reg |= EXYNOS2200_CLKRST_LINK_PCLK_SEL;
+       writel(reg, reg_phy + EXYNOS2200_DRD_CLKRST);
 }
 
 static void
@@ -2264,6 +2542,8 @@ static int exynosautov920_usbdrd_combo_phy_exit(struct phy *phy)
 
        if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI)
                exynosautov920_usbdrd_hsphy_disable(phy_drd);
+       else if (inst->phy_cfg->id == EXYNOS5_DRDPHY_PIPE3)
+               exynosautov920_usb31drd_ssphy_disable(phy_drd);
 
        /* enable PHY isol */
        inst->phy_cfg->phy_isol(inst, true);
@@ -2320,10 +2600,44 @@ static int exynosautov920_usbdrd_phy_power_off(struct phy *phy)
        return 0;
 }
 
+static const char * const exynosautov920_usb30_regulators[] = {
+       "dvdd", "vdd18",
+};
+
 static const char * const exynosautov920_usb20_regulators[] = {
        "dvdd", "vdd18", "vdd33",
 };
 
+static const struct
+exynos5_usbdrd_phy_config usb31drd_phy_cfg_exynosautov920[] = {
+       {
+               .id             = EXYNOS5_DRDPHY_PIPE3,
+               .phy_isol       = exynos5_usbdrd_phy_isol,
+               .phy_init       = exynosautov920_usb31drd_pipe3_init,
+       },
+};
+
+static const struct phy_ops exynosautov920_usb31drd_combo_ssphy_ops = {
+       .init           = exynosautov920_usbdrd_phy_init,
+       .exit           = exynosautov920_usbdrd_combo_phy_exit,
+       .power_on       = exynosautov920_usbdrd_phy_power_on,
+       .power_off      = exynosautov920_usbdrd_phy_power_off,
+       .owner          = THIS_MODULE,
+};
+
+static const
+struct exynos5_usbdrd_phy_drvdata exynosautov920_usb31drd_combo_ssphy = {
+       .phy_cfg                = usb31drd_phy_cfg_exynosautov920,
+       .phy_ops                = &exynosautov920_usb31drd_combo_ssphy_ops,
+       .pmu_offset_usbdrd0_phy = EXYNOSAUTOV920_PHY_CTRL_USB31,
+       .clk_names              = exynos5_clk_names,
+       .n_clks                 = ARRAY_SIZE(exynos5_clk_names),
+       .core_clk_names         = exynos5_core_clk_names,
+       .n_core_clks            = ARRAY_SIZE(exynos5_core_clk_names),
+       .regulator_names        = exynosautov920_usb30_regulators,
+       .n_regulators           = ARRAY_SIZE(exynosautov920_usb30_regulators),
+};
+
 static const struct phy_ops exynosautov920_usbdrd_combo_hsphy_ops = {
        .init           = exynosautov920_usbdrd_phy_init,
        .exit           = exynosautov920_usbdrd_combo_phy_exit,
@@ -2588,6 +2902,9 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
        }, {
                .compatible = "samsung,exynos990-usbdrd-phy",
                .data = &exynos990_usbdrd_phy
+       }, {
+               .compatible = "samsung,exynosautov920-usb31drd-combo-ssphy",
+               .data = &exynosautov920_usb31drd_combo_ssphy
        }, {
                .compatible = "samsung,exynosautov920-usbdrd-combo-hsphy",
                .data = &exynosautov920_usbdrd_combo_hsphy
index ab4d8be0e0738a0300395f739f559c30126d2c84..db8a7ca81080d146e355846768b08093d93a113a 100644 (file)
 
 /* exynosautov920 */
 #define EXYNOSAUTOV920_PHY_CTRL_USB20                          (0x0710)
+#define EXYNOSAUTOV920_PHY_CTRL_USB31                          (0x0714)
 #endif /* __LINUX_SOC_EXYNOS_REGS_PMU_H */