]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
fuzz: do not reuse global variable named suricata 4945/head
authorPhilippe Antoine <contact@catenacyber.fr>
Sat, 16 May 2020 12:30:13 +0000 (14:30 +0200)
committerVictor Julien <victor@inliniac.net>
Sat, 16 May 2020 17:43:19 +0000 (19:43 +0200)
src/tests/fuzz/fuzz_applayerparserparse.c
src/tests/fuzz/fuzz_decodepcapfile.c
src/tests/fuzz/fuzz_sigpcap.c

index 5aaae352b2f78dbcbcf075b025b2661a35d9ce1d..e91ac4138be0aaafae89ed249cb85fae068a1f9f 100644 (file)
@@ -29,7 +29,7 @@ AppLayerParserThreadCtx *alp_tctx = NULL;
  * destination port (uint16_t) */
 
 const uint8_t separator[] = {0x01, 0xD5, 0xCA, 0x7A};
-SCInstance suricata;
+SCInstance surifuzz;
 uint64_t forceLayer = 0;
 
 int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
@@ -59,7 +59,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
         //redirect logs to /tmp
         ConfigSetLogDirectory("/tmp/");
 
-        PostConfLoadedSetup(&suricata);
+        PostConfLoadedSetup(&surifuzz);
         alp_tctx = AppLayerParserThreadCtxAlloc();
         const char* forceLayerStr = getenv("FUZZ_APPLAYER");
         if (forceLayerStr) {
index 58244d2ea40a9f12799e3e0a3a29a22faf3354ec..da8147eb069be5e3c5281f2a5ae168ad85efcf3d 100644 (file)
@@ -16,7 +16,7 @@
 int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size);
 
 static int initialized = 0;
-SCInstance suricata;
+SCInstance surifuzz;
 
 const char configNoChecksum[] = "\
 %YAML 1.1\n\
@@ -48,7 +48,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
             abort();
         }
 
-        PostConfLoadedSetup(&suricata);
+        PostConfLoadedSetup(&surifuzz);
 
         RunModeInitialize();
         TimeModeSetOffline();
index 43b10f07657e95900906abba58e26f8bf33f1d17..83a8bba89e3a1573e15a3d257788124ce382eb07 100644 (file)
@@ -32,7 +32,7 @@ ThreadVars tv;
 DecodeThreadVars *dtv;
 //FlowWorkerThreadData
 void *fwd;
-SCInstance suricata;
+SCInstance surifuzz;
 
 const char configNoChecksum[] = "\
 %YAML 1.1\n\
@@ -155,14 +155,14 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
         if (ConfYamlLoadString(configNoChecksum, strlen(configNoChecksum)) != 0) {
             abort();
         }
-        suricata.sig_file = strdup("/tmp/fuzz.rules");
-        suricata.sig_file_exclusive = 1;
+        surifuzz.sig_file = strdup("/tmp/fuzz.rules");
+        surifuzz.sig_file_exclusive = 1;
         //loads rules after init
-        suricata.delayed_detect = 1;
+        surifuzz.delayed_detect = 1;
 
-        PostConfLoadedSetup(&suricata);
+        PostConfLoadedSetup(&surifuzz);
         PreRunPostPrivsDropInit(run_mode);
-        PostConfLoadedDetectSetup(&suricata);
+        PostConfLoadedDetectSetup(&surifuzz);
 
         memset(&tv, 0, sizeof(tv));
         dtv = DecodeThreadVarsAlloc(&tv);
@@ -197,16 +197,16 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
     }
     if (pos > 0 && pos < size) {
         // dump signatures to a file so as to reuse SigLoadSignatures
-        if (TestHelperBufferToFile(suricata.sig_file, data, pos-1) < 0) {
+        if (TestHelperBufferToFile(surifuzz.sig_file, data, pos-1) < 0) {
             return 0;
         }
     } else {
-        if (TestHelperBufferToFile(suricata.sig_file, data, pos) < 0) {
+        if (TestHelperBufferToFile(surifuzz.sig_file, data, pos) < 0) {
             return 0;
         }
     }
 
-    if (DetectEngineReload(&suricata) < 0) {
+    if (DetectEngineReload(&surifuzz) < 0) {
         return 0;
     }
     if (pos < size) {