]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cdx: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 9 Jan 2026 16:57:50 +0000 (17:57 +0100)
committerRob Herring (Arm) <robh@kernel.org>
Wed, 4 Feb 2026 02:58:13 +0000 (20:58 -0600)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Link: https://patch.msgid.link/20260109-of-for-each-compatible-scoped-v3-6-c22fa2c0749a@oss.qualcomm.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/cdx/cdx.c

index b39af2f1937f796faf83ba8e5db585b81fecd759..bbde529aaa934f3eb0884db575a6e04d4e9b86e5 100644 (file)
@@ -608,7 +608,6 @@ static ssize_t rescan_store(const struct bus_type *bus,
 {
        struct cdx_controller *cdx;
        struct platform_device *pd;
-       struct device_node *np;
        bool val;
 
        if (kstrtobool(buf, &val) < 0)
@@ -623,10 +622,9 @@ static ssize_t rescan_store(const struct bus_type *bus,
        cdx_unregister_devices(&cdx_bus_type);
 
        /* Rescan all the devices */
-       for_each_compatible_node(np, NULL, compat_node_name) {
+       for_each_compatible_node_scoped(np, NULL, compat_node_name) {
                pd = of_find_device_by_node(np);
                if (!pd) {
-                       of_node_put(np);
                        count = -EINVAL;
                        goto unlock;
                }