Fix no-dsa

Skip tests that require DSA to be available. While we're doing this
we also remove an OPENSSL_NO_DSA guard in the dhparam app that is no
longer necessary (even though DSA may not be present in our own providers
it could be available via a third party provider).

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/13599)

diff --git a/apps/dhparam.c b/apps/dhparam.c
index 58cdfd000d9a85a930e0a321004b625a8775c27e..ecb4e17db167c0cd7d75e599c10dba31b0edd7b1 100644 (file)
--- a/apps/dhparam.c
+++ b/apps/dhparam.c
@@ -47,10 +47,8 @@ const OPTIONS dhparam_options[] = {
     OPT_SECTION("General"),
     {"help", OPT_HELP, '-', "Display this summary"},
     {"check", OPT_CHECK, '-', "Check the DH parameters"},
-#ifndef OPENSSL_NO_DSA
     {"dsaparam", OPT_DSAPARAM, '-',
      "Read or generate DSA parameters, convert to DH"},
-#endif
 #ifndef OPENSSL_NO_ENGINE
     {"engine", OPT_ENGINE, 's', "Use engine e, possibly a hardware device"},
 #endif

diff --git a/test/recipes/20-test_dhparam.t b/test/recipes/20-test_dhparam.t
index 63441a5785942859463083caabee1a96884cfb90..42eef173b741549b72a473bc78816c722ad7e809 100644 (file)
--- a/test/recipes/20-test_dhparam.t
+++ b/test/recipes/20-test_dhparam.t
@@ -141,27 +141,31 @@ subtest "Generate: 512 bit PKCS3 params, generator 2, explicit PEM file" => sub
                  '-outform', 'PEM', '512' ])));
     checkdhparams("gen-pkcs3-2-512.exp.pem", "PKCS3", 2, "PEM", 512);
 };
-subtest "Generate: 512 bit X9.42 params, generator 0, PEM file" => sub {
-    plan tests => 5;
-    ok(run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-0-512.pem',
-                 '-dsaparam', '512' ])));
-    checkdhparams("gen-x942-0-512.pem", "X9.42", 0, "PEM", 512);
-};
-subtest "Generate: 512 bit X9.42 params, explicit generator 2, PEM file" => sub {
-    plan tests => 1;
-    #Expected to fail - you cannot select a generator with '-dsaparam'
-    ok(!run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-exp2-512.pem', '-2',
-                  '-dsaparam', '512' ])));
-};
-subtest "Generate: 512 bit X9.42 params, generator 5, PEM file" => sub {
-    plan tests => 1;
-    #Expected to fail - you cannot select a generator with '-dsaparam'
-    ok(!run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-5-512.pem',
-                  '-5', '-dsaparam', '512' ])));
-};
-subtest "Generate: 512 bit X9.42 params, generator 0, DER file" => sub {
-    plan tests => 5;
-    ok(run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-0-512.der',
-                 '-dsaparam', '-outform', 'DER', '512' ])));
-    checkdhparams("gen-x942-0-512.der", "X9.42", 0, "DER", 512);
-};
+SKIP: {
+    skip "Skipping tests that require DSA", 4 if disabled("dsa");
+
+    subtest "Generate: 512 bit X9.42 params, generator 0, PEM file" => sub {
+        plan tests => 5;
+        ok(run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-0-512.pem',
+                    '-dsaparam', '512' ])));
+        checkdhparams("gen-x942-0-512.pem", "X9.42", 0, "PEM", 512);
+    };
+    subtest "Generate: 512 bit X9.42 params, explicit generator 2, PEM file" => sub {
+        plan tests => 1;
+        #Expected to fail - you cannot select a generator with '-dsaparam'
+        ok(!run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-exp2-512.pem', '-2',
+                    '-dsaparam', '512' ])));
+    };
+    subtest "Generate: 512 bit X9.42 params, generator 5, PEM file" => sub {
+        plan tests => 1;
+        #Expected to fail - you cannot select a generator with '-dsaparam'
+        ok(!run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-5-512.pem',
+                    '-5', '-dsaparam', '512' ])));
+    };
+    subtest "Generate: 512 bit X9.42 params, generator 0, DER file" => sub {
+        plan tests => 5;
+        ok(run(app([ 'openssl', 'dhparam', '-out', 'gen-x942-0-512.der',
+                    '-dsaparam', '-outform', 'DER', '512' ])));
+        checkdhparams("gen-x942-0-512.der", "X9.42", 0, "DER", 512);
+    };
+}