]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
python/provision: avoid SDDL conversion in set_dir_acl()
authorRalph Boehme <slow@samba.org>
Mon, 31 Jul 2023 13:56:26 +0000 (15:56 +0200)
committerRalph Boehme <slow@samba.org>
Wed, 19 Mar 2025 14:58:32 +0000 (14:58 +0000)
This is not needed and has the potential to loose
information if the sddl code wouldn't have all features
implemented.

No intended change in behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14927

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
python/samba/provision/__init__.py

index f091ccf2f1850aba11aa86629218543aeea7641b..119ff3f49fac17b655fe309520b6e3da31ad416c 100644 (file)
@@ -1648,7 +1648,7 @@ def set_gpos_acl(sysvol, dnsdomain, domainsid, domaindn, samdb, lp, use_ntvfs, p
         acl = ndr_unpack(security.descriptor,
                          policy["nTSecurityDescriptor"][0]).as_sddl()
         policy_path = getpolicypath(sysvol, dnsdomain, str(policy["cn"]))
-        set_dir_acl(policy_path, dsacl2fsacl(acl, domainsid), lp,
+        set_dir_acl(policy_path, dsacl2fsacl(acl, domainsid, as_sddl=False), lp,
                     str(domainsid), use_ntvfs,
                     passdb=passdb)