BUG/MINOR: hlua: Only execute functions of HTTP class if the txn is HTTP ready

The flag HLUA_TXN_HTTP_RDY was added in the previous commit to know when a
function is called for a channel with a valid HTTP message or not. Of course it
also depends on the calling direction. In this commit, we allow the execution of
functions of the HTTP class only if this flag is set.

Nobody seems to use them from an unsupported context (for instance, trying to
set an HTTP header from a tcp-request rule). But it remains a bug leading to
undefined behaviors or crashes.

This patch may be backported to all versions since the 1.6. It depends on the
commits "MINOR: hlua: Add a flag on the lua txn to know in which context it can
be used" and "MINOR: hlua: Don't set request analyzers on response channel for
lua actions".

diff --git a/src/hlua.c b/src/hlua.c
index d5a3fd0de9a9607662b924f2c1fb6a972285f08c..8844ebe6720648ad71143970c5f44426a3f08da6 100644 (file)
--- a/src/hlua.c
+++ b/src/hlua.c
@@ -4766,7 +4766,7 @@ __LJMP static int hlua_http_req_get_headers(lua_State *L)
        MAY_LJMP(check_args(L, 1, "req_get_headers"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return hlua_http_get_headers(L, htxn, &htxn->s->txn->req);
@@ -4779,7 +4779,7 @@ __LJMP static int hlua_http_res_get_headers(lua_State *L)
        MAY_LJMP(check_args(L, 1, "res_get_headers"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_RES)
+       if (htxn->dir != SMP_OPT_DIR_RES || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return hlua_http_get_headers(L, htxn, &htxn->s->txn->rsp);
@@ -4815,7 +4815,7 @@ __LJMP static int hlua_http_req_rep_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 4, "req_rep_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return MAY_LJMP(hlua_http_rep_hdr(L, htxn, &htxn->s->txn->req, ACT_HTTP_REPLACE_HDR));
@@ -4828,7 +4828,7 @@ __LJMP static int hlua_http_res_rep_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 4, "res_rep_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_RES)
+       if (htxn->dir != SMP_OPT_DIR_RES || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return MAY_LJMP(hlua_http_rep_hdr(L, htxn, &htxn->s->txn->rsp, ACT_HTTP_REPLACE_HDR));
@@ -4841,7 +4841,7 @@ __LJMP static int hlua_http_req_rep_val(lua_State *L)
        MAY_LJMP(check_args(L, 4, "req_rep_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return MAY_LJMP(hlua_http_rep_hdr(L, htxn, &htxn->s->txn->req, ACT_HTTP_REPLACE_VAL));
@@ -4854,7 +4854,7 @@ __LJMP static int hlua_http_res_rep_val(lua_State *L)
        MAY_LJMP(check_args(L, 4, "res_rep_val"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_RES)
+       if (htxn->dir != SMP_OPT_DIR_RES || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return MAY_LJMP(hlua_http_rep_hdr(L, htxn, &htxn->s->txn->rsp, ACT_HTTP_REPLACE_VAL));
@@ -4883,7 +4883,7 @@ __LJMP static int hlua_http_req_del_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 2, "req_del_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return hlua_http_del_hdr(L, htxn, &htxn->s->txn->req);
@@ -4896,7 +4896,7 @@ __LJMP static int hlua_http_res_del_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 2, "res_del_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_RES)
+       if (htxn->dir != SMP_OPT_DIR_RES || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return hlua_http_del_hdr(L, htxn, &htxn->s->txn->rsp);
@@ -4925,7 +4925,7 @@ __LJMP static int hlua_http_req_add_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 3, "req_add_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return hlua_http_add_hdr(L, htxn, &htxn->s->txn->req);
@@ -4938,7 +4938,7 @@ __LJMP static int hlua_http_res_add_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 3, "res_add_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_RES)
+       if (htxn->dir != SMP_OPT_DIR_RES || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        return hlua_http_add_hdr(L, htxn, &htxn->s->txn->rsp);
@@ -4951,7 +4951,7 @@ static int hlua_http_req_set_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 3, "req_set_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        hlua_http_del_hdr(L, htxn, &htxn->s->txn->req);
@@ -4965,7 +4965,7 @@ static int hlua_http_res_set_hdr(lua_State *L)
        MAY_LJMP(check_args(L, 3, "res_set_hdr"));
        htxn = MAY_LJMP(hlua_checkhttp(L, 1));
 
-       if (htxn->dir != SMP_OPT_DIR_RES)
+       if (htxn->dir != SMP_OPT_DIR_RES || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        hlua_http_del_hdr(L, htxn, &htxn->s->txn->rsp);
@@ -4979,7 +4979,7 @@ static int hlua_http_req_set_meth(lua_State *L)
        size_t name_len;
        const char *name = MAY_LJMP(luaL_checklstring(L, 2, &name_len));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        lua_pushboolean(L, http_req_replace_stline(0, name, name_len, htxn->p, htxn->s) != -1);
@@ -4993,7 +4993,7 @@ static int hlua_http_req_set_path(lua_State *L)
        size_t name_len;
        const char *name = MAY_LJMP(luaL_checklstring(L, 2, &name_len));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        lua_pushboolean(L, http_req_replace_stline(1, name, name_len, htxn->p, htxn->s) != -1);
@@ -5007,7 +5007,7 @@ static int hlua_http_req_set_query(lua_State *L)
        size_t name_len;
        const char *name = MAY_LJMP(luaL_checklstring(L, 2, &name_len));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        /* Check length. */
@@ -5034,7 +5034,7 @@ static int hlua_http_req_set_uri(lua_State *L)
        size_t name_len;
        const char *name = MAY_LJMP(luaL_checklstring(L, 2, &name_len));
 
-       if (htxn->dir != SMP_OPT_DIR_REQ)
+       if (htxn->dir != SMP_OPT_DIR_REQ || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        lua_pushboolean(L, http_req_replace_stline(3, name, name_len, htxn->p, htxn->s) != -1);
@@ -5048,7 +5048,7 @@ static int hlua_http_res_set_status(lua_State *L)
        unsigned int code = MAY_LJMP(luaL_checkinteger(L, 2));
        const char *reason = MAY_LJMP(luaL_optlstring(L, 3, NULL, NULL));
 
-       if (htxn->dir != SMP_OPT_DIR_RES)
+       if (htxn->dir != SMP_OPT_DIR_RES || !(htxn->flags & HLUA_TXN_HTTP_RDY))
                WILL_LJMP(lua_error(L));
 
        http_res_set_status(code, reason, htxn->s);