]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
NFS storage pool: Fix libvirtd crash due to refactor edit
authorJohn Ferlan <jferlan@redhat.com>
Fri, 4 Apr 2014 13:55:00 +0000 (09:55 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Fri, 4 Apr 2014 13:55:00 +0000 (09:55 -0400)
Commit id '18642d10' refactored the call to virCommandRunRegex()
inside a new function virStorageBackendFileSystemNetFindNFSPoolSources(),
but the cut-n-paste didn't remove the "&state".  Now that state is passed
by reference, it results in a libvirtd core with a messages entry:

"...internal error: unknown storage pool type Unknow"

src/storage/storage_backend_fs.c

index 1d85871fb3825293db361707be1ed0e0de0a20e9..4e4a7aee8f8184293b73750b0348a9a0dc2539e7 100644 (file)
@@ -266,7 +266,7 @@ virStorageBackendFileSystemNetFindNFSPoolSources(virNetfsDiscoverState *state)
 
     if (virCommandRunRegex(cmd, 1, regexes, vars,
                            virStorageBackendFileSystemNetFindPoolSourcesFunc,
-                           &state, NULL) < 0)
+                           state, NULL) < 0)
         virResetLastError();
 
     virCommandFree(cmd);