seccomp: get_v2_default_action()

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/seccomp.c b/src/lxc/seccomp.c
index 1e754db221e5f43359dd1154f24c0cc2ec69f360..aae1921b48e09b972409245b9c4236fd37f4a11e 100644 (file)
--- a/src/lxc/seccomp.c
+++ b/src/lxc/seccomp.c
@@ -71,20 +71,26 @@ static uint32_t get_v2_default_action(char *line)
 
        while (*line == ' ')
                line++;
+
        /* After 'whitelist' or 'blacklist' comes default behavior. */
-       if (strncmp(line, "kill", 4) == 0)
+       if (strncmp(line, "kill", 4) == 0) {
                ret_action = SCMP_ACT_KILL;
-       else if (strncmp(line, "errno", 5) == 0) {
-               int e;
-               if (sscanf(line + 5, "%d", &e) != 1) {
-                       ERROR("Bad errno value in %s", line);
+       } else if (strncmp(line, "errno", 5) == 0) {
+               int e, ret;
+
+               ret = sscanf(line + 5, "%d", &e);
+               if (ret != 1) {
+                       ERROR("Failed to parse errno value from %s", line);
                        return -2;
                }
+
                ret_action = SCMP_ACT_ERRNO(e);
-       } else if (strncmp(line, "allow", 5) == 0)
+       } else if (strncmp(line, "allow", 5) == 0) {
                ret_action = SCMP_ACT_ALLOW;
-       else if (strncmp(line, "trap", 4) == 0)
+       } else if (strncmp(line, "trap", 4) == 0) {
                ret_action = SCMP_ACT_TRAP;
+       }
+
        return ret_action;
 }