]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 16 Jun 2025 06:25:42 +0000 (08:25 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 27 Jun 2025 00:11:08 +0000 (17:11 -0700)
Add missing DP PHY status and VCO clock configuration registers to fix
configuring the VCO rate on SM8750.  Without proper VCO rate setting, it
works on after-reset half of rate which is not enough for DP over USB to
work as seen on logs:

  [drm:msm_dp_ctrl_link_train_1_2] *ERROR* max v_level reached
  [drm:msm_dp_ctrl_link_train_1_2] *ERROR* link training #1 on phy 0 failed. ret=-11

Fixes: c4364048baf4 ("phy: qcom: qmp-combo: Add new PHY sequences for SM8750")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250616062541.7167-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-combo.c

index 8b9710a9654ab1acf8419e7f87188cbc98f8714a..f07d097b129fb7b3fad003103b7468b16c1c4390 100644 (file)
@@ -228,6 +228,9 @@ static const unsigned int qmp_v8_usb3phy_regs_layout[QPHY_LAYOUT_SIZE] = {
        [QPHY_COM_CMN_STATUS]           = QSERDES_V8_COM_CMN_STATUS,
        [QPHY_COM_BIAS_EN_CLKBUFLR_EN]  = QSERDES_V8_COM_BIAS_EN_CLKBUFLR_EN,
 
+       [QPHY_DP_PHY_STATUS]            = QSERDES_V6_DP_PHY_STATUS,
+       [QPHY_DP_PHY_VCO_DIV]           = QSERDES_V6_DP_PHY_VCO_DIV,
+
        [QPHY_TX_TX_POL_INV]            = QSERDES_V8_TX_TX_POL_INV,
        [QPHY_TX_TX_DRV_LVL]            = QSERDES_V8_TX_TX_DRV_LVL,
        [QPHY_TX_TX_EMP_POST1_LVL]      = QSERDES_V8_TX_TX_EMP_POST1_LVL,