]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix coverity 1596617
authorNeil Horman <nhorman@openssl.org>
Thu, 25 Apr 2024 12:46:21 +0000 (08:46 -0400)
committerTomas Mraz <tomas@openssl.org>
Fri, 26 Apr 2024 15:09:06 +0000 (17:09 +0200)
Somehow a double free slipped into conf_mod.c, remove it

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24263)

crypto/conf/conf_mod.c

index 23912a56ccbba58c99dd5a7aec68d3cfd5f05ae8..ccd28a146a7483c94238c810414acae1cd05eeed 100644 (file)
@@ -368,7 +368,6 @@ static CONF_MODULE *module_add(DSO *dso, const char *name,
 
  err:
     ossl_rcu_write_unlock(module_list_lock);
-    sk_CONF_MODULE_free(new_modules);
     if (tmod != NULL) {
         OPENSSL_free(tmod->name);
         OPENSSL_free(tmod);