]> git.ipfire.org Git - thirdparty/ccache.git/commitdiff
feat: Add quotes around arguments with space in logged command lines
authorJoel Rosdahl <joel@rosdahl.net>
Thu, 2 Feb 2023 19:25:34 +0000 (20:25 +0100)
committerJoel Rosdahl <joel@rosdahl.net>
Fri, 3 Feb 2023 13:22:20 +0000 (14:22 +0100)
src/Util.cpp

index e1b0d865de10cb01609939371ebc95b7933216cf..82afba8d8264837703dc1a9b7b5abb6224b5b5ac 100644 (file)
@@ -525,9 +525,11 @@ format_argv_for_logging(const char* const* argv)
     if (i != 0) {
       result += ' ';
     }
-    for (const char* arg = argv[i]; *arg; ++arg) {
-      result += *arg;
+    std::string arg(argv[i]);
+    if (arg.empty() || arg.find(' ') != std::string::npos) {
+      arg = FMT("\"{}\"", arg);
     }
+    result += arg;
   }
   return result;
 }