]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virNetTLSContextNewPath: Refactor temporary variable usage
authorPeter Krempa <pkrempa@redhat.com>
Thu, 10 Jul 2025 13:58:28 +0000 (15:58 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 18 Jul 2025 12:44:40 +0000 (14:44 +0200)
Use autofree for all temporary variables and return the result directly.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/rpc/virnettlscontext.c

index bf83857a05b72d716c7eb93b552cbacabae8eab0..f857bb2339c796a3a999c05a9761e3f7e7f7ec07 100644 (file)
@@ -308,23 +308,18 @@ static virNetTLSContext *virNetTLSContextNewPath(const char *pkipath,
                                                  bool requireValidCert,
                                                  bool isServer)
 {
-    char *cacert = NULL, *cacrl = NULL, *key = NULL, *cert = NULL;
-    virNetTLSContext *ctxt = NULL;
+    g_autofree char *cacert = NULL;
+    g_autofree char *cacrl = NULL;
+    g_autofree char *key = NULL;
+    g_autofree char *cert = NULL;
 
     if (virNetTLSContextLocateCredentials(pkipath, tryUserPkiPath, isServer,
                                           &cacert, &cacrl, &cert, &key) < 0)
         return NULL;
 
-    ctxt = virNetTLSContextNew(cacert, cacrl, cert, key,
+    return virNetTLSContextNew(cacert, cacrl, cert, key,
                                x509dnACL, priority, sanityCheckCert,
                                requireValidCert, isServer);
-
-    VIR_FREE(cacert);
-    VIR_FREE(cacrl);
-    VIR_FREE(key);
-    VIR_FREE(cert);
-
-    return ctxt;
 }
 
 virNetTLSContext *virNetTLSContextNewServerPath(const char *pkipath,