Avoid ambiguity between C++2a std::erase_if and LFTS version

These calls should have been qualified to avoid ADL anyway, but in C++2a
it becomes essential to qualify the calls in experimental::erase because
std::erase_if is also declared and the calls become ambiguous.

	* include/experimental/forward_list (experimental::erase): Qualify
	call to erase_if.
	* include/experimental/list (experimental::erase): Likewise.
	* include/std/forward_list (std::erase): Likewise.
	* include/std/list (std::erase): Likewise.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268356 138bc75d-0d04-0410-961f-82ee72b054a4

diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
index fc6f7d1a210933db83cad620d78832c42af2a859..7af725ae7bf7be0231243334df83af011d7f278e 100644 (file)
--- a/libstdc++-v3/ChangeLog
+++ b/libstdc++-v3/ChangeLog
@@ -1,5 +1,11 @@
 2019-01-29  Jonathan Wakely  <jwakely@redhat.com>
 
+       * include/experimental/forward_list (experimental::erase): Qualify
+       call to erase_if.
+       * include/experimental/list (experimental::erase): Likewise.
+       * include/std/forward_list (std::erase): Likewise.
+       * include/std/list (std::erase): Likewise.
+
        * testsuite/20_util/reference_wrapper/result_type.cc: Disable for
        C++2a.
        * testsuite/20_util/reference_wrapper/typedefs-2.cc: Likewise.

diff --git a/libstdc++-v3/include/experimental/forward_list b/libstdc++-v3/include/experimental/forward_list
index 60f0564f0658fdc695661e397c30e0933f4905cb..f6ffbf0a0af53f9b75a12e2483a1b84c2524630a 100644 (file)
--- a/libstdc++-v3/include/experimental/forward_list
+++ b/libstdc++-v3/include/experimental/forward_list
@@ -54,7 +54,9 @@ inline namespace fundamentals_v2
     erase(forward_list<_Tp, _Alloc>& __cont, const _Up& __value)
     {
       using __elem_type = typename forward_list<_Tp, _Alloc>::value_type;
-      erase_if(__cont, [&](__elem_type& __elem) { return __elem == __value; });
+      std::experimental::erase_if(__cont, [&](__elem_type& __elem) {
+         return __elem == __value;
+      });
     }
 
   namespace pmr {

diff --git a/libstdc++-v3/include/experimental/list b/libstdc++-v3/include/experimental/list
index 13c33f02e721ee866406ba9f52fd08ce01d892d0..2b7a331e63afb5ae3ada99ff0815f61482f164ab 100644 (file)
--- a/libstdc++-v3/include/experimental/list
+++ b/libstdc++-v3/include/experimental/list
@@ -54,7 +54,9 @@ inline namespace fundamentals_v2
     erase(list<_Tp, _Alloc>& __cont, const _Up& __value)
     {
       using __elem_type = typename list<_Tp, _Alloc>::value_type;
-      erase_if(__cont, [&](__elem_type& __elem) { return __elem == __value; });
+      experimental::erase_if(__cont, [&](__elem_type& __elem) {
+         return __elem == __value;
+      });
     }
 
 namespace pmr {

diff --git a/libstdc++-v3/include/std/forward_list b/libstdc++-v3/include/std/forward_list
index 3d3b6d4f5f6dd315017709848b7986cd0c330931..9d6cc40593babc6b582a82e7053102c1a7d928a0 100644 (file)
--- a/libstdc++-v3/include/std/forward_list
+++ b/libstdc++-v3/include/std/forward_list
@@ -78,8 +78,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
     erase(forward_list<_Tp, _Alloc>& __cont, const _Up& __value)
     {
       using __elem_type = typename forward_list<_Tp, _Alloc>::value_type;
-      return erase_if(__cont,
-                     [&](__elem_type& __elem) { return __elem == __value; });
+      return std::erase_if(__cont, [&](__elem_type& __elem) {
+         return __elem == __value;
+      });
     }
 _GLIBCXX_END_NAMESPACE_VERSION
 } // namespace std

diff --git a/libstdc++-v3/include/std/list b/libstdc++-v3/include/std/list
index 7b02e8685d48e4ee89cb4f520436857d1f379085..8d6ac198c9a720853795a12848b5aec5142ec21d 100644 (file)
--- a/libstdc++-v3/include/std/list
+++ b/libstdc++-v3/include/std/list
@@ -102,8 +102,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
     erase(list<_Tp, _Alloc>& __cont, const _Up& __value)
     {
       using __elem_type = typename list<_Tp, _Alloc>::value_type;
-      return erase_if(__cont,
-                     [&](__elem_type& __elem) { return __elem == __value; });
+      return std::erase_if(__cont, [&](__elem_type& __elem) {
+         return __elem == __value;
+      });
     }
 _GLIBCXX_END_NAMESPACE_VERSION
 } // namespace std