]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Report domain name in unexpectedly closed monitor message
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 9 May 2023 07:51:40 +0000 (10:51 +0300)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 9 May 2023 11:57:28 +0000 (14:57 +0300)
When QEMU closes the monitor suddenly, the following error
message is reported:

  internal error: qemu unexpectedly closed the monitor: ...

And this works. But other error messages produced in the same
function include domain name too. Do that for the unexpectedly
closed monitor message too.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_monitor.c

index 71ebd356ad7e157a56d13190ce3ebc4a0aad7ff6..dacf161971827393915831d314f30b0a6126df2e 100644 (file)
@@ -513,15 +513,18 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED,
 
     if (error || mon->goteof) {
         if (hangup && mon->logFunc != NULL) {
+            g_autofree char *errmsg = NULL;
+
             /* Check if an error message from qemu is available and if so, use
              * it to overwrite the actual message. It's done only in early
              * startup phases or during incoming migration when the message
              * from qemu is certainly more interesting than a
              * "connection reset by peer" message.
              */
-            mon->logFunc(mon,
-                         _("qemu unexpectedly closed the monitor"),
-                         mon->logOpaque);
+
+            errmsg = g_strdup_printf(_("QEMU unexpectedly closed the monitor (vm='%1$s')"),
+                                     mon->domainName);
+            mon->logFunc(mon, errmsg, mon->logOpaque);
             virCopyLastError(&mon->lastError);
             virResetLastError();
         }