]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virNetServerGetClients: Remove pointless cleanup
authorPeter Krempa <pkrempa@redhat.com>
Wed, 4 Aug 2021 09:36:31 +0000 (11:36 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 6 Aug 2021 06:53:26 +0000 (08:53 +0200)
'list' will always be NULL when reaching 'virObjectListFreeCount' thus
we can remove the call as well as the 'ret' variable which was only ever
equal to 'nclients' at the point when we returned the value.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/rpc/virnetserver.c

index bb1a96b65eb2ad38a67aaced3b9057f7e8ebf8b5..b3214883ee77a718b11df2eaa1d31ea13b929fad 100644 (file)
@@ -1077,7 +1077,6 @@ int
 virNetServerGetClients(virNetServer *srv,
                        virNetServerClient ***clts)
 {
-    int ret = -1;
     size_t i;
     size_t nclients = 0;
     virNetServerClient **list = NULL;
@@ -1090,11 +1089,10 @@ virNetServerGetClients(virNetServer *srv,
     }
 
     *clts = g_steal_pointer(&list);
-    ret = nclients;
 
-    virObjectListFreeCount(list, nclients);
     virObjectUnlock(srv);
-    return ret;
+
+    return nclients;
 }
 
 virNetServerClient *