]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
soc: renesas: renesas-soc: Release 'chipid' from ioremap()
authorLi Yang <lidaxian@hust.edu.cn>
Fri, 31 Mar 2023 09:55:44 +0000 (17:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:11:02 +0000 (23:11 +0900)
[ Upstream commit fc187a46a8e682f0f1167b230792b88de01ceaa0 ]

Smatch reports:

drivers/soc/renesas/renesas-soc.c:536 renesas_soc_init() warn:
'chipid' from ioremap() not released on lines: 475.

If soc_dev_atrr allocation is failed, function renesas_soc_init()
will return without releasing 'chipid' from ioremap().

Fix this by adding function iounmap().

Fixes: cb5508e47e60 ("soc: renesas: Add support for reading product revision for RZ/G2L family")
Signed-off-by: Li Yang <lidaxian@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230331095545.31823-1-lidaxian@hust.edu.cn
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/renesas/renesas-soc.c

index 468ebce1ea88bf61ed364e173279da63ae0dbde0..51191d1a6dd1d8858f83f9822fce4689a25872cf 100644 (file)
@@ -471,8 +471,11 @@ static int __init renesas_soc_init(void)
        }
 
        soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);
-       if (!soc_dev_attr)
+       if (!soc_dev_attr) {
+               if (chipid)
+                       iounmap(chipid);
                return -ENOMEM;
+       }
 
        np = of_find_node_by_path("/");
        of_property_read_string(np, "model", &soc_dev_attr->machine);